fix: use dynamic imports for plugins construction #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystall-bitquill
force-pushed
the
optional-dependencies
branch
from
c3e8be0 to
afdced0
Compare
crystall-bitquill
added
the
ready for review
joyc-bq
reviewed
Jun 14, 2024
| @@ -0,0 +1,34 @@ | |||
| /* | |||
There was a problem hiding this comment.
maybe we should change the name to read_write_splitting_plugin_factory.ts and read_write_splitting_plugin.ts to match the other file names
joyc-bq
approved these changes
Jun 14, 2024
crystall-bitquill
force-pushed
the
optional-dependencies
branch
from
afdced0 to
7c16643
Compare
crystall-bitquill
force-pushed
the
optional-dependencies
branch
4 times, most recently
from
320643c to
2a41a2f
Compare
crystall-bitquill
force-pushed
the
optional-dependencies
branch
from
2a41a2f to
2c56695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Users will only have the dependencies of the plugins they require. This change adds separation between plugins and their factories with dynamic imports in order to prevent errors from occurring when a user does not have a dependency required by a plugin they are not using. For example, if not using the AWS Secrets Manager plugin, the
@aws-sdk/client-secrets-managerpackage should not be required.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.