Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: efm2 #371

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat: efm2 #371

merged 1 commit into from
Feb 12, 2025

Conversation

joyc-bq
Copy link
Contributor

@joyc-bq joyc-bq commented Jan 16, 2025 •
edited
Loading

Summary

Enhanced host monitoring plugin ver.2 (redesign)

Description

Redesigned version of Host Monitoring Plugin (aka EFM)
Minor EFM fixes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joyc-bq joyc-bq added the wip Pull requests that are a work in progress label Jan 16, 2025
@joyc-bq joyc-bq force-pushed the efm2 branch 3 times, most recently from 765f928 to cec0010 Compare January 22, 2025 02:11
@joyc-bq joyc-bq marked this pull request as ready for review January 22, 2025 18:22
@joyc-bq joyc-bq removed the wip Pull requests that are a work in progress label Jan 22, 2025
@joyc-bq joyc-bq requested a review from a team as a code owner January 27, 2025 18:10
karenc-bq
karenc-bq reviewed Jan 28, 2025
View reviewed changes
common/lib/plugins/efm2/host_monitoring2_connection_plugin.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/host_monitoring2_connection_plugin.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/host_monitoring2_connection_plugin.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/host_monitoring2_connection_plugin.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor_service.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Outdated Show resolved Hide resolved
crystall-bitquill
crystall-bitquill reviewed Jan 28, 2025
View reviewed changes
common/lib/plugins/efm/host_monitoring_connection_plugin.ts Show resolved Hide resolved
common/lib/plugins/efm2/host_monitoring2_connection_plugin.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/host_monitoring2_connection_plugin.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor_service.ts Outdated Show resolved Hide resolved
common/lib/utils/locales/en.json Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Outdated Show resolved Hide resolved
common/lib/plugins/efm2/monitor.ts Outdated Show resolved Hide resolved
@joyc-bq joyc-bq force-pushed the efm2 branch 2 times, most recently from e7551a0 to 9c6277c Compare February 6, 2025 17:32
@karenc-bq
Copy link
Contributor

EFM and EFM2 seem to be missing a piece of code converting monitoring_xxx properties to xxx connection properties before calling checking connection status. Otherwise code look good to me.

@joyc-bq joyc-bq force-pushed the efm2 branch 2 times, most recently from 7a3108b to 5738ab8 Compare February 7, 2025 18:17
@joyc-bq joyc-bq force-pushed the efm2 branch 6 times, most recently from 734d092 to d2b52be Compare February 12, 2025 18:46
@joyc-bq joyc-bq merged commit 64227d1 into main Feb 12, 2025
7 of 8 checks passed
@joyc-bq joyc-bq deleted the efm2 branch February 12, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenc-bq karenc-bq karenc-bq approved these changes

@crystall-bitquill crystall-bitquill crystall-bitquill left review comments

@sophia-bq sophia-bq sophia-bq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyc-bq @karenc-bq @crystall-bitquill @sophia-bq