Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/352 #352 Vue Frontend won't build for prod and local #353

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

giusedroid
Copy link

@giusedroid giusedroid commented Nov 4, 2022

Issue #, if available: #352

Description of changes: addressing local and deployment build issues for website.

  • python2 is depricated on most OS, so it should not be used in the build script. This prevented the build for deployment on my machines (macOS and Linux)
  • fixed dependencies versions. Amplify is now at patch 42 (at the time of writing) and it had introduced breaking changes to the authenticator component. Before this, you allowed patch automatic upgrade which broke the build
  • added a bit of documentation on how to make changes to the front-end app

questions:

  • why is package-lock.json gitignored? It would have prevented dep drift (I think). Can I gitinclude it?
  • somebody will have to look at security issues :( a lot of dependencies include critical vulnerabilities, but at least it buids and deploys now. I will open a new issue once this is merged in. Consider using something like dependabot to receive punctual security alerts.
added 2358 packages, and audited 2359 packages in 36s

134 packages are looking for funding
  run `npm fund` for details

59 vulnerabilities (1 low, 14 moderate, 20 high, 24 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

I love this project!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@giusedroid giusedroid mentioned this pull request Nov 4, 2022
6 tasks
@giusedroid giusedroid changed the title Bug/352 #352 Bug/352 #352 Vue Frontend won't build for prod and local Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant