Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staticSite initialization and improve import statements #24

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KennyDizi
Copy link

@KennyDizi KennyDizi commented Sep 6, 2024

PR Type

bug_fix, enhancement


Description

  • Fixed the initialization of the staticSite property in ControlPlaneStack.
  • Improved import statements by using * as path for consistency.
  • Corrected trailing spaces in control-plane-stack.ts.
  • Enhanced JSON formatting in core-appplane-stack.ts for better readability.

Changes walkthrough

Relevant files
Bug fix
control-plane-stack.ts
Fix staticSite initialization and improve imports               

server/lib/bootstrap-template/control-plane-stack.ts

  • Changed import statement for path to use * as path.
  • Fixed trailing spaces in the code.
  • Initialized staticSite as a class property.
  • +4/-4     
    Enhancement
    core-appplane-stack.ts
    Improve path import and JSON formatting                                   

    server/lib/bootstrap-template/core-appplane-stack.ts

  • Changed import statement for path to use * as path.
  • Improved formatting of JSON in PolicyDocument.
  • +14/-14 

    By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

    @KennyDizi KennyDizi changed the title Fix admin site staticSite initialization Fix staticSite initialization and improve import statements Sep 6, 2024
    @KennyDizi
    Copy link
    Author

    🌟 🎇 I've updated the PR description to match the latest commit (69b5a28).

    @KennyDizi
    Copy link
    Author

    @Hoseong-Seo Would you take a look at this PR?

    @Hoseong-Seo
    Copy link
    Contributor

    Hi!!!
    Thank you so~ much for your interest.
    Could you describe a little more about a bug?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants