From ad1ee05252e8e7a451c7663603f9de2514e04580 Mon Sep 17 00:00:00 2001 From: Jeremynadal33 <36603814+Jeremynadal33@users.noreply.github.com> Date: Tue, 27 Aug 2024 10:00:15 +0200 Subject: [PATCH] changed GlueColumn base class (#424) --- CHANGELOG.md | 1 + dbt/adapters/glue/column.py | 4 ++-- tests/unit/test_column.py | 9 +++++++++ 3 files changed, 12 insertions(+), 2 deletions(-) create mode 100644 tests/unit/test_column.py diff --git a/CHANGELOG.md b/CHANGELOG.md index 0050c875..1255ed32 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ - Fix session provisioning timeout and delay handling - Add on_schema_change possibility - Fix table materialization for Delta models +- Change GlueColumn parent from base Column to SparkColumn ## v1.8.1 - Fix typo in README.md diff --git a/dbt/adapters/glue/column.py b/dbt/adapters/glue/column.py index 222daea6..97d0982c 100644 --- a/dbt/adapters/glue/column.py +++ b/dbt/adapters/glue/column.py @@ -1,11 +1,11 @@ from dataclasses import dataclass from typing import ClassVar, Dict -from dbt.adapters.base.column import Column +from dbt.adapters.spark.column import SparkColumn @dataclass -class GlueColumn(Column): +class GlueColumn(SparkColumn): # Overwriting dafult string types to support glue # TODO: Convert to supported glue types as needed # Please ref: https://github.com/dbt-athena/dbt-athena/blob/main/dbt/adapters/athena/column.py diff --git a/tests/unit/test_column.py b/tests/unit/test_column.py new file mode 100644 index 00000000..e1ff464c --- /dev/null +++ b/tests/unit/test_column.py @@ -0,0 +1,9 @@ +import unittest + +from dbt.adapters.glue.column import GlueColumn + + +class TestGlueColumn(unittest.TestCase): + def test_column_quote(self): + test_column = GlueColumn("col_name", "INT") + self.assertEqual(test_column.quoted, "`col_name`") \ No newline at end of file