Skip to content

Commit

Permalink
changed GlueColumn base class (#424)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeremynadal33 authored Aug 27, 2024
1 parent 242400f commit ad1ee05
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- Fix session provisioning timeout and delay handling
- Add on_schema_change possibility
- Fix table materialization for Delta models
- Change GlueColumn parent from base Column to SparkColumn

## v1.8.1
- Fix typo in README.md
Expand Down
4 changes: 2 additions & 2 deletions dbt/adapters/glue/column.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
from dataclasses import dataclass
from typing import ClassVar, Dict

from dbt.adapters.base.column import Column
from dbt.adapters.spark.column import SparkColumn


@dataclass
class GlueColumn(Column):
class GlueColumn(SparkColumn):
# Overwriting dafult string types to support glue
# TODO: Convert to supported glue types as needed
# Please ref: https://github.com/dbt-athena/dbt-athena/blob/main/dbt/adapters/athena/column.py
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/test_column.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import unittest

from dbt.adapters.glue.column import GlueColumn


class TestGlueColumn(unittest.TestCase):
def test_column_quote(self):
test_column = GlueColumn("col_name", "INT")
self.assertEqual(test_column.quoted, "`col_name`")

0 comments on commit ad1ee05

Please sign in to comment.