Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix managed policy #762

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix managed policy #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85ac2d2
fix managed policy
iakov-aws Mar 26, 2024
0ead34a
update python for checkov
iakov-aws Mar 26, 2024
f360b8a
add checkov dep
iakov-aws Mar 26, 2024
08b41cd
add checkov dep
iakov-aws Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/security-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.10'
python-version: '3.11'
- name: Install cfn-lint
run: |
pip install pylint
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.11'
python-version: '3.10'
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand All @@ -139,10 +139,10 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.10'
python-version: '3.11'
- name: Install checkov
run: |
pip install checkov
pip install -U schema checkov
- name: Checkov scan
run: |
checkov --directory ./terraform-modules
6 changes: 3 additions & 3 deletions cfn-templates/cid-cfn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ Resources:
Resource:
- !Sub 'arn:${AWS::Partition}:quicksight:${AWS::Region}:${AWS::AccountId}:dataset/*/ingestion/*'
ManagedPolicyArns:
- !Sub arn:${AWS::Partition}:iam:policy/service-role/AWSLambdaBasicExecutionRole
- !Sub arn:${AWS::Partition}:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
Metadata:
cfn_nag:
rules_to_suppress:
Expand Down Expand Up @@ -669,7 +669,7 @@ Resources:
Action: quicksight:DescribeUser
Resource: !Sub 'arn:${AWS::Partition}:quicksight:*:${AWS::AccountId}:user/default/${QuickSightUser}' # region=* as at this moment we do not know the Identity region where QS stores users
ManagedPolicyArns:
- !Sub arn:${AWS::Partition}:iam:policy/service-role/AWSLambdaBasicExecutionRole
- !Sub arn:${AWS::Partition}:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole

InitLambdaExecutionRoleWorkGroupPolicy:
Type: AWS::IAM::Policy
Expand Down Expand Up @@ -756,7 +756,7 @@ Resources:
- sts:AssumeRole
Path: /
ManagedPolicyArns:
- !Sub arn:${AWS::Partition}:iam:policy/service-role/AWSLambdaBasicExecutionRole
- !Sub arn:${AWS::Partition}:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
CustomResourceProcessPath:
Type: AWS::Lambda::Function
Properties:
Expand Down
Loading