Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unknown parameter error fix for DBClusterParameterGroup #180

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

riddhi2910
Copy link

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jaypipes April 5, 2024 07:31
Copy link

ack-prow bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: riddhi2910
Once this PR has been reviewed and has the lgtm label, please assign vijtrip2 for approval by writing /assign @vijtrip2 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2024
Copy link

ack-prow bot commented Apr 5, 2024

Hi @riddhi2910. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2024
@riddhi2910
Copy link
Author

/test rds-kind-e2e

Update to ACK runtime `v0.34.0`, code-generator `v0.34.0` (aws-controllers-k8s#184)
Copy link

ack-prow bot commented Aug 30, 2024

@riddhi2910: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rds-kind-e2e 8d2cd9e link true /test rds-kind-e2e
rds-verify-attribution 8d2cd9e link true /test rds-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwilms1971
Copy link

When do we expect this to be fixed and integrated?

I am experiencing this error when trying to create a custom DB cluster parameter group setting values for shared_preload_libraries as follows:

apiVersion: v1
items:

  • apiVersion: rds.services.k8s.aws/v1alpha1
    kind: DBClusterParameterGroup
    metadata:
    annotations:
    argocd.argoproj.io/tracking-id: terms-database:rds.services.k8s.aws/DBClusterParameterGroup:terms/london-termsdb-cluster-pg16-parameter-group
    kubectl.kubernetes.io/last-applied-configuration: |
    {"apiVersion":"rds.services.k8s.aws/v1alpha1","kind":"DBClusterParameterGroup","metadata":{"annotations":{"argocd.argoproj.io/tracking-id":"terms-database:rds.services.k8s.aws/DBClusterParameterGroup:terms/london-termsdb-cluster-pg16-parameter-group"},"name":"london-termsdb-cluster-pg16-parameter-group","namespace":"terms"},"spec":{"description":"Custom parameters for Terms DB cluster in London running PostgreSQL 16","family":"aurora-postgresql16","name":"london-termsdb-cluster-pg16-parameter-group","parameterOverrides":null}}
    creationTimestamp: "2024-09-18T03:10:51Z"
    finalizers:
    • finalizers.rds.services.k8s.aws/DBClusterParameterGroup
      generation: 1
      name: london-termsdb-cluster-pg16-parameter-group
      namespace: terms
      resourceVersion: "463905"
      uid: b3b860a1-f074-4c06-b8b8-7282893294d6
      spec:
      description: Custom parameters for Terms DB cluster in London running PostgreSQL
      16
      family: aurora-postgresql16
      name: london-termsdb-cluster-pg16-parameter-group
      status:
      ackResourceMetadata:
      arn: arn:aws:rds:eu-west-2:1234567890:cluster-pg:london-termsdb-cluster-pg16-parameter-group
      ownerAccountID: "1234567890"
      region: eu-west-2
      conditions:
    • message: 'unknown parameter: shared_preload_libraries'
      status: "True"
      type: ACK.Terminal
    • lastTransitionTime: "2024-09-18T13:10:52Z"
      message: Resource not synced
      reason: resource is in terminal condition
      status: "False"
      type: ACK.ResourceSynced
      parameterOverrideStatuses:
    • applyMethod: pending-reboot
      applyType: static
      parameterName: shared_preload_libraries
      parameterValue: pg_stat_statements,pgaudit
      kind: List
      metadata:
      resourceVersion: ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants