loadbalancer.elbv2 tags not reconciled

[michaelvl]

Describe the bug

The following were experienced with the elbv2 controller version 1.0.4 (last as time of writing) configured with reconcile.defaultResyncPeriod: 60.

I created a resource of type loadbalancer.elbv2.services.k8s.aws with a single tag:

  tags:
    - key: foo2
      value: bar2

I applied the resource and a loadbalancer with the given tag were created as expected. I then updated the tags to

  tags:
    - key: foo2
      value: bar2
    - key: foo3
      value: bar3

and reapplied the resource, however, the tags were not reconciled even after the resource status reported Resource synced successfully with a timestap after my resource update.

I also tried overwriting the foo2 tag using the web UI and this change was not reverted by the controller either.

The loadbalancer was created with the following attribute:

attributes:
  - key: routing.http.drop_invalid_header_fields.enabled
    value: "true"

and changing the value of this was reconciled.

Environment

• Kubernetes version: 1.31
• Using EKS (yes/no), yes, 1.31
• AWS service targeted: elbv2

[michaelhtm]

Hey @michaelvl, seems like the tag update logic was not implemented https://github.com/aws-controllers-k8s/elbv2-controller/blob/1a79c825e462343f981f2eb35c2ea368df5e0436/pkg/resource/load_balancer/hooks.go#L111-L132
it seems pretty simple to implement..if anyone wants to give it a shot please reply to the thread, thanks :)

[delinak]

@michaelhtm hi, I can work on this