-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go1.x to provided.al2 migration #230
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# This file is autogenerated, do not edit; | ||
# changes will be undone by the next 'generate' command. | ||
|
||
.PHONY: build | ||
build: | ||
cfn generate | ||
env GOARCH=amd64 GOOS=linux go build -ldflags="-s -w" -tags="lambda.norpc,$(TAGS)" -o bin/bootstrap cmd/main.go |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,9 +9,13 @@ Globals: | |
Resources: | ||
TypeFunction: | ||
Type: AWS::Serverless::Function | ||
Metadata: | ||
BuildMethod: go1.x | ||
Properties: | ||
Handler: handler | ||
Runtime: go1.x | ||
Handler: bootstrap | ||
Runtime: provided.al2 | ||
Architectures: | ||
- x86_64 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there a reason this is only x86_64? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It wasn't clear to me what to do here, particularly as it's an example. |
||
CodeUri: bin/ | ||
# Uncomment to test with AWS resources | ||
# Environment: | ||
|
@@ -20,7 +24,11 @@ Resources: | |
|
||
TestEntrypoint: | ||
Type: AWS::Serverless::Function | ||
Metadata: | ||
BuildMethod: go1.x | ||
Properties: | ||
Handler: handler | ||
Runtime: go1.x | ||
Handler: bootstrap | ||
Runtime: provided.al2 | ||
Architectures: | ||
- x86_64 | ||
CodeUri: bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the extra condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pulled from cloudformation-cli
https://github.com/aws-cloudformation/cloudformation-cli/blob/9311ae5da95a2364410b8e6649500d18bb54cfcc/src/rpdk/core/templates/resource-role.yml#L18-L24