Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switching to xcbeautify instead of xcpretty #3945

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Jan 2, 2025

Description

This PR replaces xcpretty with the faster xcbeautify. The change is done mainly because the latest version of xcpretty has an annoying bug that fails to properly display the output when a test fails, rendering it pretty useless.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas requested a review from a team as a code owner January 2, 2025 22:09
@ruisebas ruisebas merged commit abd17e5 into main Jan 3, 2025
115 checks passed
@ruisebas ruisebas deleted the ruisebas/using-xcbeautify branch January 3, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants