chore: Update label actions #3807
Conversation
API Breakage Report✅ No Public API Breaking Change detected |
.github/workflows/issue_comment.yml
Outdated
| @@ -8,7 +8,7 @@ jobs: | |||
| notify: | |||
| runs-on: ubuntu-latest | |||
| permissions: {} | |||
| if: ${{ !github.event.issue.pull_request && !contains(fromJSON('["MEMBER", "OWNER"]'), github.event.comment.author_association) }} | |||
| if: ${{ !github.event.issue.pull_request }} | |||
There was a problem hiding this comment.
I rather keep this filter to avoid sending notifications for comments from maintainers
There was a problem hiding this comment.
The if statement was moved down to each of the steps
There was a problem hiding this comment.
This notify job only has one step, which just runs the command. Unless i'm blatantly missing something 🤔
There was a problem hiding this comment.
Oh sorry, correct.
If you all would prefer, I can remove it. I brought this up with the Android team and we decided to remove it because we wanted to still be notified when a maintainer opened a new issue. This ensures everyone is aware of the issue coming in, not just the person that created it.
There was a problem hiding this comment.
But this action is for comments being added to issues, not for issues being opened.
I also very much like not being notified for comments from us :P.
But we can check with the team as well
| run: | | ||
| gh issue edit $ISSUE_NUMBER --repo $REPOSITORY_NAME --remove-label "pending-community-response" | ||
| - name: add pending-maintainer-response when new community comment received | ||
| if: ${{ !contains(fromJSON('["MEMBER", "OWNER"]'), github.event.comment.author_association) }} |
There was a problem hiding this comment.
IIRC for this filter to work you will need to set your aws-amplify org membership visibility to Public, otherwise the runner won't be able to see it.
There was a problem hiding this comment.
This is no different than the filter above that was already being used?
There was a problem hiding this comment.
Yeah, everybody in the Swift team made their membership public in order for this to work. You guys in the Android team will probably need to do the same.
There was a problem hiding this comment.
Got it, I don't remember doing this but we can check. We've had this type of filter used in other places and working well, so maybe we had already done that as well.
There was a problem hiding this comment.
Cool! I might be mixing things up with the ops metrics lambda needing this permission instead of the GH action 😅
But I do remember it was needed somewhere 😬
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3807 +/- ##
==========================================
- Coverage 68.77% 68.52% -0.25%
==========================================
Files 1080 1080
Lines 37608 37608
==========================================
- Hits 25864 25770 -94
- Misses 11744 11838 +94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
API Breakage Report✅ No Public API Breaking Change detected |
Description
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.