Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Temporary using xcodeproj's commit that bumps rexml #3796

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

sebaland
Copy link
Member

Description

This PR uses Xcodeproj's latest main commit so that its dependency to rexml can be upgraded.

We're doing this temporary until they release a proper new version, at which point we will point to that one.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested a review from a team as a code owner July 29, 2024 18:11
Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
Func Array.unique() has generic signature change from <Element where Element == Amplify.Model> to <Element where Element == any Amplify.Model>
Func Predictions.Convert.Request.speechToText(url:) has generic signature change from <Input, Options, Output where Input == Foundation.URL, Options == Amplify.Predictions.Convert.SpeechToText.Options, Output == _Concurrency.AsyncThrowingStream<Amplify.Predictions.Convert.SpeechToText.Result, Swift.Error>> to <Input, Options, Output where Input == Foundation.URL, Options == Amplify.Predictions.Convert.SpeechToText.Options, Output == _Concurrency.AsyncThrowingStream<Amplify.Predictions.Convert.SpeechToText.Result, any Swift.Error>>

@github-actions github-actions bot requested a review from a team as a code owner July 29, 2024 18:16
Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
Func Array.unique() has generic signature change from <Element where Element == Amplify.Model> to <Element where Element == any Amplify.Model>
Func Predictions.Convert.Request.speechToText(url:) has generic signature change from <Input, Options, Output where Input == Foundation.URL, Options == Amplify.Predictions.Convert.SpeechToText.Options, Output == _Concurrency.AsyncThrowingStream<Amplify.Predictions.Convert.SpeechToText.Result, Swift.Error>> to <Input, Options, Output where Input == Foundation.URL, Options == Amplify.Predictions.Convert.SpeechToText.Options, Output == _Concurrency.AsyncThrowingStream<Amplify.Predictions.Convert.SpeechToText.Result, any Swift.Error>>

@sebaland sebaland merged commit 2d3b505 into main Jul 30, 2024
@sebaland sebaland deleted the ruisebas/dependency branch July 30, 2024 00:22
yaroluchko pushed a commit to yaroluchko/amplify-swift-keychain-sharing that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants