Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update privacy info #3777

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix(core): update privacy info #3777

merged 1 commit into from
Jul 16, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jul 12, 2024

Issue #

#3776

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 marked this pull request as ready for review July 16, 2024 13:59
@harsh62 harsh62 requested a review from a team as a code owner July 16, 2024 13:59
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.95%. Comparing base (151cac6) to head (8d81b48).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (151cac6) and HEAD (8d81b48). Click for more details.

HEAD has 20 uploads less than BASE
Flag BASE (151cac6) HEAD (8d81b48)
unit_tests 11 1
DataStore_plugin_unit_test 1 0
Geo_plugin_unit_test 1 0
Predictions_plugin_unit_test 1 0
Amplify 1 0
Analytics_plugin_unit_test 1 0
PushNotifications_plugin_unit_test 1 0
AWSPluginsCore 1 0
Auth_plugin_unit_test 1 0
API_plugin_unit_test 1 0
Storage_plugin_unit_test 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3777      +/-   ##
==========================================
- Coverage   68.54%   62.95%   -5.59%     
==========================================
  Files        1079       25    -1054     
  Lines       37580      961   -36619     
==========================================
- Hits        25758      605   -25153     
+ Misses      11822      356   -11466     
Flag Coverage Δ
API_plugin_unit_test ?
AWSPluginsCore ?
Amplify ?
Analytics_plugin_unit_test ?
Auth_plugin_unit_test ?
DataStore_plugin_unit_test ?
Geo_plugin_unit_test ?
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test ?
PushNotifications_plugin_unit_test ?
Storage_plugin_unit_test ?
unit_tests 62.95% <ø> (-5.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh62 harsh62 merged commit 49af55d into main Jul 16, 2024
69 of 80 checks passed
@harsh62 harsh62 deleted the fix/3776 branch July 16, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants