Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve build failure in Amplify Core unit test for Xcode 16 beta 2 #3768

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

phantumcode
Copy link
Contributor

Issue #

Description

Resolving compile error in Amplify Core unit tests when building with Xcode 16 beta 2.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner July 3, 2024 19:25
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.46%. Comparing base (6f65406) to head (2a76236).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3768      +/-   ##
==========================================
- Coverage   68.47%   68.46%   -0.02%     
==========================================
  Files        1079     1079              
  Lines       37571    37571              
==========================================
- Hits        25726    25722       -4     
- Misses      11845    11849       +4     
Flag Coverage Δ
API_plugin_unit_test 68.83% <ø> (-0.04%) ⬇️
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.59% <ø> (-0.07%) ⬇️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.48% <ø> (+<0.01%) ⬆️
DataStore_plugin_unit_test 81.29% <ø> (ø)
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.46% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantumcode phantumcode merged commit b243384 into main Jul 3, 2024
79 checks passed
@phantumcode phantumcode deleted the phantum/xcode16_beta2_build_failure branch July 3, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants