-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data): Gen2 hasOne associatedFields compile issue #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
commented
May 15, 2024
Amplify/Categories/DataStore/Model/Internal/Schema/ModelSchema+Definition.swift
Outdated
Show resolved
Hide resolved
lawmicha
force-pushed
the
fix.data.has-one-compile
branch
from
June 5, 2024 20:41
b21358e
to
d089dba
Compare
lawmicha
force-pushed
the
fix.data.has-one-compile
branch
from
July 16, 2024 04:50
d089dba
to
55d3f7f
Compare
lawmicha
force-pushed
the
fix.data.has-one-compile
branch
from
July 16, 2024 04:56
55d3f7f
to
f8fd33b
Compare
lawmicha
force-pushed
the
fix.data.has-one-compile
branch
from
July 16, 2024 05:16
f8fd33b
to
7fcb2ce
Compare
lawmicha
force-pushed
the
fix.data.has-one-compile
branch
from
July 16, 2024 05:25
7fcb2ce
to
58b1346
Compare
lawmicha
force-pushed
the
fix.data.has-one-compile
branch
from
July 16, 2024 05:38
58b1346
to
2cb4714
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
==========================================
- Coverage 68.54% 68.49% -0.05%
==========================================
Files 1079 1079
Lines 37580 37591 +11
==========================================
- Hits 25758 25749 -9
- Misses 11822 11842 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
harsh62
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#3699 #3735
Description
This PR allows has-one to reference multiple CodingKey's of the associated model by having an
associatedFieldNames
, which is the extension of the single valueassociatedFieldName
. This was a change added in Gen2's code generation logic.The related documentation for testing can be found starting at https://docs.amplify.aws/swift/build-a-backend/data/data-modeling/relationships/#model-a-one-to-one-relationship
The tests for this documentation can be found in GraphQLCartCustomer4Tests
General Checklist
https://github.com/aws-amplify/amplify-swift/actions/runs/9951987862
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.