release: Amplify JS release #13212
Merged
release: Amplify JS release #13212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(api-graphql): improve error handling
- Use GraphApiError to create errors to be thrown
* error message field remained the same as before
* added recoverySuggestion field for each error case
- Created createGraphQLResultWithError utility for rewrapping error into GraphQLResult format
* fix(auth): signup should always return a userId * add unit tests * Update packages/auth/__tests__/providers/cognito/signUp.test.ts Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com> * address feedback --------- Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com> Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
… core (#13108) * chore(repo): setup the base for lint __tests__ codebase * chore(adapter-nextjs): run yarn lint:fix * chore(adapter-nextjs): manual fix linter reported erros * chore(aws-amplify): run yarn lint:fix Please enter the commit message for your changes. Lines starting * chore(aws-amplify): add camelcase var name exception: phone_number * chore(core): run yarn lint:fix * chore(core): manual fix linter reported errors under __tests__ * apply suggestions * turn off node callback function convention check * do not mock console functions globaly but noopify them * apply suggestions * Revert "do not mock console functions globaly but noopify them" This reverts commit 913b11e. * refactor a no-op function * remove // eslint-disable-next-line no-new
jimblanc
approved these changes
Apr 2, 2024
HuiSF
approved these changes
Apr 2, 2024
ashwinkumar6
approved these changes
Apr 2, 2024
erinleigh90
approved these changes
Apr 2, 2024
david-mcafee
approved these changes
Apr 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.