feat(auth): refractor passwordless auth interface #12718

AllanZhengYP · 2023-12-18T17:21:35Z

Description of changes

Set up passwordless APIs to reflect approved API designs

Checklist

PR description included
yarn test passes
Tests are changed or added
Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This reverts commit ff12951.

…wordless" This reverts commit e5ad6e3.

This reverts commit 1587fb6.

packages/auth/src/index.ts

packages/auth/src/providers/cognito/apis/signIn.ts

packages/auth/src/providers/cognito/apis/signUp.ts

packages/auth/src/providers/cognito/types/inputs.ts

packages/auth/src/providers/cognito/apis/signUp.ts

calebpollman

Great start! Mostly left feedback/questions on the interfaces

packages/auth/src/providers/cognito/apis/signIn.ts

packages/auth/src/providers/cognito/types/inputs.ts

packages/auth/src/providers/cognito/types/outputs.ts

packages/auth/src/providers/cognito/types/inputs.ts

packages/auth/src/providers/cognito/types/outputs.ts

packages/auth/src/providers/cognito/types/inputs.ts

jimblanc

Looks good! Some nits, and I agree with some feedback from the other reviewers.

packages/auth/src/providers/cognito/apis/signIn.ts

packages/auth/src/providers/cognito/apis/signUp.ts

packages/auth/src/providers/cognito/types/inputs.ts

packages/auth/src/providers/cognito/apis/signUp.ts

packages/auth/src/providers/cognito/types/outputs.ts

israx

Thanks @AllanZhengYP for putting this together. If the outputs are going to be discriminated unions, wondering if it make sense to explicitly define the type values for isSignUpComplete and isSignedIn ?

I also noticed that this PR is not changing the confirmSignIn API correct ?

packages/core/src/singleton/Auth/types.ts

…sswordless without breaking users

israx

LGTM

Samaritan1011001 · 2023-12-26T18:59:34Z

packages/auth/src/providers/cognito/apis/signUp.ts

+) {
+	const { options, passwordless } = input;
+	if (passwordless) {
+		// Iterate through signUpPasswordless calls to make TypeScript happy


Whats the issue without iterating?

calebpollman

Left some feedback/thoughts on alignment of interface naming conventions and replacing the usage of existing input/output interfaces (SignInInput, SignInOutput, etc). Also would like to see the extraneous optional never keys removed 😅

packages/auth/src/providers/cognito/types/inputs.ts

packages/auth/src/providers/cognito/apis/signIn.ts

packages/auth/src/providers/cognito/utils/signUpHelpers.ts

This reverts commit c8c8015.

AllanZhengYP added 15 commits December 4, 2023 17:24

feat(auth): reorganize passwordless API types

dda135d

fix(auth): more strict types

a7fd772

feat(auth): integrate passwordless flow to existing API

7a68e72

feat(auth): attempt to use fn override to reduce return type

7e774a0

feat(auth): merge authFlowType with passwordlessFlow(rev2.1)

ff12951

Revert "feat(auth): merge authFlowType with passwordlessFlow(rev2.1)"

b7533e1

This reverts commit ff12951.

feat(auth): attempt to not highlight password when using passwordless

e5ad6e3

Revert "feat(auth): attempt to not highlight password when using pass…

4ce4ef2

…wordless" This reverts commit e5ad6e3.

feat(auth): move passwordless options to options

9ebe8be

feat(auth): attempt to make overload to generics

1587fb6

Revert "feat(auth): attempt to make overload to generics"

379822f

This reverts commit 1587fb6.

feat(auth): make signIn option stricter by disallowing unrelated options

627bcf0

feat(auth): rename passwordlessFlow to passwordlessMethod

11307bd

feat(auth): move password connection type to the top-level auth input

ece8164

feat(auth): move all passwordless options to single top-level option

b43be2a

AllanZhengYP mentioned this pull request Dec 20, 2023

feat(auth): refactor the passwordless interfaces #12709

Closed

4 tasks

AllanZhengYP force-pushed the feat/passwordless-auth-zheallan-rev4.1 branch from 4c49d2a to b646849 Compare December 20, 2023 01:15

AllanZhengYP marked this pull request as ready for review December 20, 2023 01:15

AllanZhengYP requested a review from a team as a code owner December 20, 2023 01:15

feat(auth): remove any types in function overloading

9a31e50

AllanZhengYP force-pushed the feat/passwordless-auth-zheallan-rev4.1 branch from b646849 to 9a31e50 Compare December 20, 2023 01:21

AllanZhengYP requested a review from a team as a code owner December 20, 2023 01:21

AllanZhengYP requested a review from calebpollman December 20, 2023 20:24

HuiSF reviewed Dec 21, 2023

View reviewed changes

Samaritan1011001 reviewed Dec 21, 2023

View reviewed changes

packages/auth/src/providers/cognito/apis/signUp.ts Outdated Show resolved Hide resolved

calebpollman reviewed Dec 21, 2023

View reviewed changes

jimblanc reviewed Dec 21, 2023

View reviewed changes

israx reviewed Dec 21, 2023

View reviewed changes

packages/auth/src/providers/cognito/apis/signUp.ts Outdated Show resolved Hide resolved

israx reviewed Dec 21, 2023

View reviewed changes

packages/auth/src/providers/cognito/types/outputs.ts Outdated Show resolved Hide resolved

israx reviewed Dec 21, 2023

View reviewed changes

packages/auth/src/providers/cognito/types/outputs.ts Outdated Show resolved Hide resolved

israx reviewed Dec 21, 2023

View reviewed changes

calebpollman reviewed Dec 21, 2023

View reviewed changes

packages/core/src/singleton/Auth/types.ts Show resolved Hide resolved

AllanZhengYP added 5 commits December 22, 2023 13:18

feat(auth): address feedbacks

42e5368

fix(auth): keep using SignIn(Up)Input(Output) interface to support pa…

1185dc9

…sswordless without breaking users

chore(auth): fix docs

eabe033

fix(auth): revert change to unionize SignIn(Up)Input(Output) interface

386068b

feat(auth): remove passwordless from passwordless type names

2c37458

AllanZhengYP requested review from jimblanc, HuiSF, Samaritan1011001, calebpollman and israx December 22, 2023 23:52

israx approved these changes Dec 26, 2023

View reviewed changes

Samaritan1011001 approved these changes Dec 26, 2023

View reviewed changes

calebpollman reviewed Dec 28, 2023

View reviewed changes

AllanZhengYP added 4 commits December 27, 2023 18:01

chore(auth): address feedbacks

6ec48d2

chore(auth): apply more naming suggestions

c8c8015

Revert "chore(auth): apply more naming suggestions"

c6a26ee

This reverts commit c8c8015.

chore(auth): fix some of typedoc links

300aeb5

AllanZhengYP merged commit 5412477 into aws-amplify:feat/passwordless-auth Dec 28, 2023
25 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(auth): refractor passwordless auth interface #12718

feat(auth): refractor passwordless auth interface #12718

AllanZhengYP commented Dec 18, 2023 •

edited

Loading

calebpollman left a comment

jimblanc left a comment

israx left a comment •

edited

Loading

israx left a comment

Samaritan1011001 Dec 26, 2023

calebpollman left a comment

feat(auth): refractor passwordless auth interface #12718

feat(auth): refractor passwordless auth interface #12718

Conversation

AllanZhengYP commented Dec 18, 2023 • edited Loading

Description of changes

Checklist

calebpollman left a comment

Choose a reason for hiding this comment

jimblanc left a comment

Choose a reason for hiding this comment

israx left a comment • edited Loading

Choose a reason for hiding this comment

israx left a comment

Choose a reason for hiding this comment

Samaritan1011001 Dec 26, 2023

Choose a reason for hiding this comment

calebpollman left a comment

Choose a reason for hiding this comment

AllanZhengYP commented Dec 18, 2023 •

edited

Loading

israx left a comment •

edited

Loading