Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id token doesn't contain ClientMetadata after refresh #13379

Open
rashidwiizb opened this issue May 14, 2024 · 16 comments
Open

id token doesn't contain ClientMetadata after refresh #13379

rashidwiizb opened this issue May 14, 2024 · 16 comments
Labels
Auth Related to Auth components/category Cognito Related to cognito issues feature-request Request a new feature Service Team Issues asked to the Service Team VP Version parity issues between v5 and v6

Comments

@rashidwiizb
Copy link

this way I m using signIn
"@aws-amplify/react-native": "^1.1.1",
"aws-amplify": "^6.3.1",
"react-native": "0.73.2",

const userSignIn = await signIn({
username: userName,
password: password,
options: {
clientMetadata: {
roleType: "Student"
}
}
});

I already attache pre token lambda trigger on Cognito for customise the id token . so I get the roleType in it on idTojeb when signing success . But when this idToken expires I get the new id token from amplify itself so in that idToken I didn't get this roleType

@github-actions github-actions bot added the pending-triage Issue is pending triage label May 14, 2024
@mattcreaser
Copy link
Member

Hi @rashidwiizb, react-native is actually part of the amplify-js project. I'll transfer this issue over to that repository.

@mattcreaser mattcreaser transferred this issue from aws-amplify/amplify-android May 14, 2024
@cwomack cwomack self-assigned this May 14, 2024
@cwomack cwomack added Auth Related to Auth components/category question General question and removed pending-triage Issue is pending triage labels May 14, 2024
@cwomack
Copy link
Member

cwomack commented May 16, 2024

Hello, @rashidwiizb 👋. I think we may need to understand how your Auth flow is structured to better help here. How are you persisting the roleType field and attaching it to the iDToken? Can you share the lambda hook implementation and how to reproduce this? Thanks!

@TomMuehlegger
Copy link

We are facing the same issue. When providing the ClientMetadata to the signIn method, we are getting the right JWT token from Cognito (adding a claim, depending on the ClientMetadata, to the token via the PreTokenGeneration trigger in Cognito).

But when doing the fetchAuthSession({ forceRefresh: true }); via Amplify, the ClientMetadata is not provided to the PreTokenGeneration trigger and thus, this information is missing in the JWT token provided by the fetchAuthSession call.

We are using the latest "aws-amplify" version 6.3.2.
Thanks...

@rashidwiizb
Copy link
Author

rashidwiizb commented May 17, 2024

Hi @mattcreaser thanks for the reply.

@cwomack my pre-token lambda triggers is

const handler = async (event, context,callback) => {
  try {
        let roleType = '';
        if (event.triggerSource === 'TokenGeneration_Authentication') {
            roleType = event.request?.clientMetadata?.roleType;
            cachedRoleType = roleType;
        } else if (event.triggerSource === 'TokenGeneration_RefreshTokens') {
            roleType = cachedRoleType;
        }
        
        event.response = {
            claimsOverrideDetails: {
                claimsToAddOrOverride: {
                    'roleType': roleType
                },                
            },
        };

        return callback(null, event);
    } catch (error) {
        console.error('Error processing Pre Token Generation:', error);
        throw error;
    }
};

export { handler };

when I signin I pass the roleType in ClientMetadata and I get that roletype in idtoken,but when the idtoken is expires amplify itself refresh and get the new idtoken and access token but in that id token the roleType is empty strings "", that mean when refreshing the lambda doesn't get the ClientMetadata . Is there any way to fix this ?

@israx
Copy link
Member

israx commented May 17, 2024

hello everyone. Passing clientMetadata while refreshing tokens is not supported at this time. However we are aware of this feature and will be working on it. I'll mark this issue as a feature request for now.

@israx israx added feature-request Request a new feature and removed question General question labels May 17, 2024
@cwomack cwomack removed their assignment May 17, 2024
@rashidwiizb
Copy link
Author

Hi @israx

I am configuring AWS Amplify with different user pools and client IDs according to the role I pass to the amplify_Config function. This works correctly, and Amplify is configured with the appropriate pool ID and client ID based on the role.

When I first select the "Student" role, it configures for the student, and then the sign-in happens successfully, and the user is logged in. However, after the current user logs out, if I choose another role and call amplify_Config in useEffect again, it reconfigures correctly. Then, when I call sign-in, Amplify tries to sign in with the previously configured user pool and client ID, resulting in an error.

But when I reload the page after selecting the role and configuring Amplify, it works fine. Is there a way to achieve this without reloading the page?

my amplify_Config

export const amplify_Config = async (role) => {
return new Promise((resolve, reject) => {
let poolId = '';
let clientId = '';
role = role.charAt(0).toUpperCase() + role.slice(1);

    if (role === "Student") {
        poolId = config.AWS_CONFIG.STUDENT_POOL_ID;
        clientId = config.AWS_CONFIG.STUDENT_CLIENT;
    } else if (role === "Teacher") {
        poolId = config.AWS_CONFIG.TEACHER_POOL_ID;
        clientId = config.AWS_CONFIG.TEACHER_CLIENT;
    } else if (role === "Parent") {
        poolId = config.AWS_CONFIG.PARENT_POOL_ID;
        clientId = config.AWS_CONFIG.PARENT_CLIENT;
    }

    // console.log("amp config", { role }, { poolId }, { clientId });
    Amplify.configure({
        Auth: {
            Cognito: {
                userPoolId: poolId,
                userPoolClientId: clientId,
                loginWith: {
                    oauth: {
                        domain: '',
                        responseType: 'code',
                        scopes: config.AWS_CONFIG.SCOPE,
                        redirectSignIn: [''],
                        redirectSignOut: [''],
                    }
                },
            },
        },
    });
    resolve();
});

}

the useeffect and reload in signIn page after selecting role

const reload = () => {
var refresh = localStorage.getItem('reload');
setTimeout(function () {
if (refresh === null) {
window.location.reload();
window.localStorage.setItem('reload', "1");
}
});

setTimeout(function () {
localStorage.removeItem('reload')
}, 1000);
}
}
useEffect(() => {
const config = async() =>{
return await amplify_Config(role);
}
if(role){
dispatch(selecteRole(role));
config();
reload() // page reloading
},[role])

@israx
Copy link
Member

israx commented May 21, 2024

Hello @rashidwiizb . Can you try the following ?

  1. call Amplify.getConfigure before calling the signIn API and see if the configure was updated.
  2. listening for the signOut hub event and calling Amplify.configure after that.

If that doesn't work. Can you open a different GH issue regarding the problem with Amplify.configure , so we can assist you in a better way?

@rashidwiizb
Copy link
Author

Hi @israx first I call signOut for current logged user and then I reconfigured the amplify according with passed role after configuring I call Amplify.getConfigure and this gives the new configuration , but after that I call signIn it uses the previous configured client id and userpool id for signing;

Amplify.configure({
Auth: {
Cognito: {
userPoolId: poolId,
userPoolClientId: clientId,
loginWith: {
oauth: {
domain: '',
responseType: 'code',
scopes: config.AWS_CONFIG.SCOPE,
redirectSignIn: [''],
redirectSignOut: [''],
}
},
},
},
});

console.log("new configuration",Amplify.getConfigure());

@cwomack cwomack added the VP Version parity issues between v5 and v6 label May 29, 2024
@leo-hsk
Copy link

leo-hsk commented Jun 19, 2024

hello everyone. Passing clientMetadata while refreshing tokens is not supported at this time. However we are aware of this feature and will be working on it. I'll mark this issue as a feature request for now.

@israx People are waiting for this feature for years: #6731
Is there any prospect of when this will be worked on?

@kashee337
Copy link

@israx
Is this issue addressed in the roadmap? Please let me know if there are any updates.

@github-actions github-actions bot added the pending-maintainer-response Issue is pending a response from the Amplify team. label Dec 12, 2024
@cwomack
Copy link
Member

cwomack commented Dec 12, 2024

@leo-hsk and @kashee337, we don't have any updates for this feature at this point. However, I'll bring it to our product team and review this internally again.

@github-actions github-actions bot removed the pending-maintainer-response Issue is pending a response from the Amplify team. label Dec 12, 2024
@enchorb
Copy link

enchorb commented Feb 11, 2025

+1

@github-actions github-actions bot added the pending-maintainer-response Issue is pending a response from the Amplify team. label Feb 11, 2025
@HuiSF HuiSF removed the pending-maintainer-response Issue is pending a response from the Amplify team. label Feb 11, 2025
@henriwoodcock
Copy link

Is there any update on this or workarounds? Is there a recipe to add a custom auth challenge to refresh tokens? I see that's the way to get clientMetadata through

@github-actions github-actions bot added the pending-maintainer-response Issue is pending a response from the Amplify team. label Feb 18, 2025
@jjarvisp jjarvisp added Cognito Related to cognito issues Service Team Issues asked to the Service Team and removed pending-maintainer-response Issue is pending a response from the Amplify team. labels Feb 18, 2025
@joon-won
Copy link
Member

joon-won commented Feb 21, 2025

Hey @henriwoodcock unfortunately passing clientMetadata in refreshing auth token is currently not supported due to service endpoint's limitation. If your intended use case is for customizing idToken like OP, have you considered using userAttributes instead?

@henriwoodcock
Copy link

henriwoodcock commented Feb 21, 2025

@joon-won I have considered this, but the issue is the attribute is dynamic. So when the user first logs, they select an ID, we then pass is through a custom auth flow and then add it to the access token. For subsequent refreshes we want the access token to contain the exact same claims as the previous one. I worry I'd be doing a lot of admin update user calls at run-time just before refresh in our endpoint

@github-actions github-actions bot added the pending-maintainer-response Issue is pending a response from the Amplify team. label Feb 21, 2025
@joon-won
Copy link
Member

Hmm, can we make the user id not change? If it's an id, I would expect it does not change much, in that case we might be able to set up some attribute custom:user-id and set up pre token generation lambda to pick that up from userAttributes on refresh which will also contain user-id in this case, and have your lambda form the same access token. In pre token generation lambda, you can capture your refresh logic by checking triggerSource be TokenGeneration_RefreshTokens. It might not require many calls to be made before refresh in that way. Could you share your token refresh logic to dive deeper into this?

@github-actions github-actions bot removed the pending-maintainer-response Issue is pending a response from the Amplify team. label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auth Related to Auth components/category Cognito Related to cognito issues feature-request Request a new feature Service Team Issues asked to the Service Team VP Version parity issues between v5 and v6
Projects
None yet
Development

No branches or pull requests