Merge pull request #99 from Canas/fix-arn-undefined-error

fix: gracefully handle logName on undefined Arn
aws-actions · Jul 13, 2022 · 95cc38b · 95cc38b
2 parents 208ba49 + f7983ad
commit 95cc38b
Show file tree

Hide file tree

Showing 3 changed files with 288,680 additions and 58,694 deletions.
diff --git a/code-build.js b/code-build.js
@@ -234,13 +234,18 @@ function buildSdk() {
 }
 
 function logName(Arn) {
-  const [logGroupName, logStreamName] = Arn.split(":log-group:")
-    .pop()
-    .split(":log-stream:");
-  if (logGroupName === "null" || logStreamName === "null")
-    return {
-      logGroupName: undefined,
-      logStreamName: undefined,
-    };
-  return { logGroupName, logStreamName };
+  const logs = {
+    logGroupName: undefined,
+    logStreamName: undefined,
+  };
+  if (Arn) {
+    const [logGroupName, logStreamName] = Arn.split(":log-group:")
+      .pop()
+      .split(":log-stream:");
+    if (logGroupName !== "null" && logStreamName !== "null") {
+      logs.logGroupName = logGroupName;
+      logs.logStreamName = logStreamName;
+    }
+  }
+  return logs;
 }