fix: parse interval and backoff as integers

aws-actions · Jan 29, 2023 · 160321e · 160321e
1 parent 2ffcfe8
commit 160321e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/code-build.js b/code-build.js
@@ -198,9 +198,15 @@ function githubInputs() {
     .filter((i) => i !== "");
 
   const updateInterval =
-    core.getInput("update-interval", { required: false }) || 1000 * 30;
+    parseInt(
+      core.getInput("update-interval", { required: false }) || "30",
+      10
+    ) * 1000;
   const updateBackOff =
-    core.getInput("update-back-off", { required: false }) || 1000 * 15;
+    parseInt(
+      core.getInput("update-back-off", { required: false }) || "15",
+      10
+    ) * 1000;
 
   return {
     projectName,

diff --git a/test/code-build-test.js b/test/code-build-test.js
@@ -54,8 +54,8 @@ describe("githubInputs", () => {
   const sha = "1234abcd-12ab-34cd-56ef-1234567890ab";
   const pullRequestSha = "181600acb3cfb803f4570d0018928be5d730c00d";
 
-  const updateInterval = "5";
-  const updateBackOff = "10";
+  const updateInterval = 5;
+  const updateBackOff = 10;
 
   it("build basic parameters for codeBuild.startBuild", () => {
     // This is how GITHUB injects its input values.
@@ -157,8 +157,8 @@ describe("githubInputs", () => {
   });
   it("can handle configuring update call-rate", () => {
     process.env[`INPUT_PROJECT-NAME`] = projectName;
-    process.env[`INPUT_UPDATE-INTERVAL`] = updateInterval;
-    process.env[`INPUT_UPDATE-BACK-OFF`] = updateBackOff;
+    process.env[`INPUT_UPDATE-INTERVAL`] = `${updateInterval}`;
+    process.env[`INPUT_UPDATE-BACK-OFF`] = `${updateBackOff}`;
     process.env[`GITHUB_REPOSITORY`] = repoInfo;
     process.env[`GITHUB_SHA`] = sha;
     const { context } = require("@actions/github");
@@ -168,10 +168,10 @@ describe("githubInputs", () => {
 
     expect(test)
       .to.haveOwnProperty("updateInterval")
-      .and.to.equal(updateInterval);
+      .and.to.equal(updateInterval * 1000);
     expect(test)
       .to.haveOwnProperty("updateBackOff")
-      .and.to.equal(updateBackOff);
+      .and.to.equal(updateBackOff * 1000);
   });
 });
 
@@ -358,7 +358,7 @@ describe("inputs2Parameters", () => {
 });
 
 describe("waitForBuildEndTime", () => {
-  const defaultConfig = { updateInterval: 30, updateBackOff: 15 };
+  const defaultConfig = { updateInterval: 10, updateBackOff: 10 }; // NOTE: milliseconds
   it("basic usages", async () => {
     let count = 0;
     const buildID = "buildID";