Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to actions/upload-artifact@v4 #140

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Upgrade to actions/upload-artifact@v4 #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ runs:

- id: upload-logs
if: ${{ inputs.debug == 'true' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally aware of what other changes need to be made. Haven't read the migration process docs yet. But this is causing all use of this Action to fail in CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly for the purposes of fixing this issue might be totally viable to just delete this entire Step. Most folks probably not running in Debug mode. Can add later and adjust params as needed for v4

Copy link
Contributor Author

@maschwenk maschwenk Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just forked this Action and unblocked ourselves. Seems this Action does not require any special publish/build process for it to work 🎉

Edit: It does, but the binaries are committed to source and the change to fix this is just in yaml-land, so just forking the Action and pointing to it works just fine

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That alone should be enough, I think.

Uploaded artifacts are now immutable, so if you try to upload two with the same names in the same pipeline, previously it would have updated the files and now it won't. But this action isn't trying to do that, so I think it should just work.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maschwenk for the PR and you are correct, this should just be a YAML update. I can publish a new package tonight once I am off of work. I may just pull this entirely in the future to minimize dependencies and the fact that it isn't being leveraged a whole lot.

with:
name: cache-apt-pkgs-logs_${{ env.CACHE_KEY }}
path: ~/cache-apt-pkgs/*.log
Expand Down
Loading