Replace WMIC with powershell cmd #4034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leidwang
force-pushed
the
wmic_replacement
branch
2 times, most recently
from
97073f0 to
194ab37
Compare
leidwang
force-pushed
the
wmic_replacement
branch
2 times, most recently
from
1c9d9ea to
7c4813a
Compare
leidwang
force-pushed
the
wmic_replacement
branch
5 times, most recently
from
ae6028c to
9f86791
Compare
From Win11-24H2, WMIC is an optional feature for Windows, And it will be fully removed in the future.So replace the related cmd Signed-off-by: Leidong Wang <leidwang@redhat.com>
leidwang
force-pushed
the
wmic_replacement
branch
from
9f86791 to
d1bcda5
Compare
|
Test 271 acceptance with win2022,win11,win1032 and win2016 guests, this patch worked. |
|
Hi @XueqiangWei @nanliu-r @fbq815 Would you please help test this MR, it is mainly for wmic repalcement.Thanks. |
|
Acceptance test looks good. |
|
balloon_hotplug test cases now passed in Win2025 |
|
Hi @yanan-fu @YongxueHong Would you please help review this MR?Thanks. |
mcasquer
reviewed
Jan 24, 2025
| return out if out else [] | ||
| c_name, c_value = cond.split("=") | ||
| cmd = ( | ||
| 'powershell -command "Get-CimInstance -ClassName Win32_LogicalDisk | Where-Object {$_.%s -like %s}' |
There was a problem hiding this comment.
The disk needs to be under single quotes, same you've done in utils_netperf.py and replace the existing ones by double quotes
Suggested change
| 'powershell -command "Get-CimInstance -ClassName Win32_LogicalDisk | Where-Object {$_.%s -like %s}' | |
| "powershell -command \"Get-CimInstance -ClassName Win32_LogicalDisk | Where-Object {$_.%s -like '%s'}" |
mcasquer
reviewed
Jan 24, 2025
| return mapping | ||
| return {} | ||
| cmd = ( | ||
| 'powershell -command "Get-CimInstance -ClassName Win32_Diskdrive | Where-Object {$_.SerialNumber -eq %s}' |
There was a problem hiding this comment.
Same as above
Suggested change
| 'powershell -command "Get-CimInstance -ClassName Win32_Diskdrive | Where-Object {$_.SerialNumber -eq %s}' | |
| "powershell -command \"Get-CimInstance -ClassName Win32_Diskdrive | Where-Object {$_.SerialNumber -eq '%s'}" |
mcasquer
reviewed
Jan 24, 2025
| results.append(vals[0]) | ||
| else: | ||
| results.append(dict(zip(keys, vals))) | ||
| return results if results else [] |
There was a problem hiding this comment.
@leidwang
Another comment here, this implementation seems to no longer return a map, so this will probably break all the calls to this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Win11-24H2, WMIC is an optional feature for Windows, And it will be fully removed in the future.So replace the related cmd
ID: 3268