Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text selection on table row triggers visit #3708

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes an issue when a user was trying to select a piece of text on a table row (with click to visit record option on) and that would trigger the visit to that record instead of ignoring it.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. go to a table with click_row_to_view_record option on
  2. select some text on a row
  3. observe that thebrowser does not visit that record.

Manual reviewer: please leave a comment with output from the test if that's the case.

@github-actions github-actions bot added the Fix label Mar 1, 2025
Copy link

codeclimate bot commented Mar 1, 2025

Code Climate has analyzed commit 79b38d4 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 0a7efa1 into main Mar 2, 2025
21 checks passed
@adrianthedev adrianthedev deleted the fix/text-selection-on-table-row branch March 2, 2025 12:12
Copy link
Contributor

github-actions bot commented Mar 2, 2025

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant