Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self Service Reports : Added a switch to enable metabase setup , a button to check sync status and a button to refresh tables #1338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ombhardwajj
Copy link
Contributor

No description provided.

… to check sync status and a button to refresh tables
@ombhardwajj ombhardwajj changed the title Self Service REports : Added a switch to enable metabase setup , a butto to check sync status and a button to refresh tables Self Service REports : Added a switch to enable metabase setup , a button to check sync status and a button to refresh tables Sep 16, 2024
@ombhardwajj ombhardwajj changed the title Self Service REports : Added a switch to enable metabase setup , a button to check sync status and a button to refresh tables Self Service Reports : Added a switch to enable metabase setup , a button to check sync status and a button to refresh tables Sep 16, 2024
@1t5j0y 1t5j0y self-requested a review September 26, 2024 12:55
useEffect(() => {
if (errorMessage) {
const timer = setTimeout(() => {
setErrorMessage("");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to hide error message after 10 seconds. Use a toast if you want to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright will try to use toast !

Copy link
Contributor

@1t5j0y 1t5j0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback around clearing error message

@ombhardwajj
Copy link
Contributor Author

Alright will try to use toast !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Code Review Ready
Development

Successfully merging this pull request may close these issues.

2 participants