Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1116 | Enhance concept screen to display form, section, and question… #1267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#1116 | Enhance concept screen to display form, section, and question… #1267

wants to merge 2 commits into from

Conversation

d1vyanshu-kumar
Copy link

Screenshot 2024-06-24 at 4 53 51 PM

vinayvenu
vinayvenu requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@vinayvenu vinayvenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best to get the group information directly from the form instead of calling the /exports for every form usage.

Also, we need to figure out errors will affect the page instead of silently swallowing them

src/formDesigner/components/ConceptDetails.js Outdated
});
}
} catch (error) {
console.error("Error fetching usage data:", error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the method fails? Will the screen still work?

src/formDesigner/components/ConceptDetails.js Outdated

if (usageResponse.data.forms) {
usageResponse.data.forms.forEach(form => {
fetchFormData(form.formUUID);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing this, why not enhance the /web/concept/usage url to give you all the data instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayvenu vinayvenu vinayvenu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d1vyanshu-kumar @vinayvenu