Bump Go version to 1.23 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maranqz
force-pushed
the
bump-to-1.22
branch
3 times, most recently
from
2542a85 to
fc0780f
Compare
Pull Request Test Coverage Report for Build 10707440316Details
💛 - Coveralls |
maranqz
commented
Aug 3, 2024
maranqz
commented
Aug 3, 2024
maranqz
commented
Aug 3, 2024
maranqz
force-pushed
the
bump-to-1.22
branch
3 times, most recently
from
6b6ae33 to
b977746
Compare
2. Fix skipping code error in test
maranqz
force-pushed
the
bump-to-1.22
branch
2 times, most recently
from
10f9c00 to
1adfe1b
Compare
This was referenced Aug 3, 2024
maranqz
commented
Aug 3, 2024
maranqz
commented
Aug 3, 2024
maranqz
commented
Aug 3, 2024
|
Hey Ilia. Please consider that gh action started upgrading go 1.21 to 1.22 automatically. There's an article and a possible fix for this: https://brandur.org/fragments/go-version-matrix |
maranqz
force-pushed
the
bump-to-1.22
branch
3 times, most recently
from
10e0dfc to
7f61def
Compare
maranqz
force-pushed
the
bump-to-1.22
branch
2 times, most recently
from
466bf16 to
2957245
Compare
maranqz
force-pushed
the
bump-to-1.22
branch
5 times, most recently
from
15cbb44 to
022b894
Compare
2. solved toolchain golan problem 3. explain how to generate go.mod with compatible with old versions
maranqz
commented
Aug 30, 2024
maranqz
commented
Aug 30, 2024
2. added context converter in mongo
maranqz
force-pushed
the
bump-to-1.22
branch
from
4142ecd to
b191111
Compare
maranqz
force-pushed
the
bump-to-1.22
branch
from
bd204cd to
40dd1cc
Compare
vladjong
approved these changes
Sep 4, 2024
Khranovskiy
previously approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tests always pass because no exit code is sent for tests.
I fixed this, and also the driver tests only run on go versions and higher that are installed in go.mod.