Add more verbose logs

avito-tech · Jun 21, 2020 · bdf3b2f · bdf3b2f
1 parent 499adc7
commit bdf3b2f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/Sources/QueueCommunication/DefaultQueueCommunicationService.swift b/Sources/QueueCommunication/DefaultQueueCommunicationService.swift
@@ -36,9 +36,9 @@ public class DefaultQueueCommunicationService: QueueCommunicationService {
         deployments: [DeploymentDestination],
         completion: @escaping (Either<Set<WorkerId>, Error>) -> ()
     ) {
+        Logger.debug("Making request for workers to utilize. Version: \(version), deployments: \(deployments) ")
         do {
             let masterPort = try remoteQueueDetector.findMasterQueuePort(timeout: requestTimeout)
-            Logger.debug("Found master queue port: \(masterPort)")
 
             let requestSender = requestSenderProvider.requestSender(
                 socketAddress: SocketAddress(host: socketHost, port: masterPort)

diff --git a/Sources/QueueCommunication/DefaultRemoteQueueDetector.swift b/Sources/QueueCommunication/DefaultRemoteQueueDetector.swift
@@ -1,6 +1,7 @@
 import Foundation
-import RemotePortDeterminer
+import Logging
 import Models
+import RemotePortDeterminer
 
 public enum RemoteQueueDetectorError: Error, CustomStringConvertible {
     case noMasterQueueFound
@@ -41,10 +42,11 @@ public final class DefaultRemoteQueueDetector: RemoteQueueDetector {
                 left.value > right.value
             }
 
-        guard let masterPort = sortedQueues.first?.key else {
+        guard let masterQueue = sortedQueues.first else {
             throw RemoteQueueDetectorError.noMasterQueueFound
         }
 
-        return masterPort
+        Logger.debug("Found master queue with version \(masterQueue.value) at port \(masterQueue.key)")
+        return masterQueue.key
     }
 }
diff --git a/Sources/QueueCommunication/DefaultWorkerUtilizationStatusPoller.swift b/Sources/QueueCommunication/DefaultWorkerUtilizationStatusPoller.swift
@@ -32,6 +32,7 @@ public class DefaultWorkerUtilizationStatusPoller: WorkerUtilizationStatusPoller
 
     public func startPolling() {
         pollingTrigger.start { [weak self] timer in
+            Logger.debug("Fetching workers to utilize")
             self?.fetchWorkersToUtilize()
         }
     }
@@ -64,7 +65,7 @@ public class DefaultWorkerUtilizationStatusPoller: WorkerUtilizationStatusPoller
                         )
                     )
                 } catch {
-                    Logger.error(error.localizedDescription)
+                    Logger.error("Error in fetching workers to utilze: \(error.localizedDescription)")
                 }
         })
     }

diff --git a/Sources/QueueServer/Endpoints/ToggleWorkersSharingEndpoint.swift b/Sources/QueueServer/Endpoints/ToggleWorkersSharingEndpoint.swift
@@ -21,6 +21,8 @@ public final class ToggleWorkersSharingEndpoint: RESTEndpoint {
     }
 
     public func handle(payload: ToggleWorkersSharingPayload) throws -> VoidPayload {
+        Logger.debug("Change workers sharing feature state to :\(payload.status)")
+
         switch payload.status {
         case .disabled:
             poller.stopPollingAndRestoreDefaultConfig()