Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ergo-services/ergo #4901

Closed
wants to merge 2 commits into from
Closed

Add ergo-services/ergo #4901

wants to merge 2 commits into from

Conversation

Nezteb
Copy link

@Nezteb Nezteb commented May 29, 2023

This was attempted in 2020 but the PR was closed. #2998

Please provide package links to:

Make sure that you've checked the boxes below that apply before you submit PR.

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.
  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process.

Copy link
Owner

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2998 (review)

What we asked for in this code review has not been solved so far, that is why it was not accepted

@Nezteb
Copy link
Author

Nezteb commented May 29, 2023

@avelino Ahhh, got it.

I've made corresponding items for each issue:

@yassinebenaid
Copy link
Collaborator

Project is already listed. In fact, ergo is the first on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants