Skip to content

Commit

Permalink
Merge branch 'use-importer'
Browse files Browse the repository at this point in the history
  • Loading branch information
jonlamb-gh committed Mar 28, 2024
2 parents ab8c035 + 81c26de commit 07af51b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
13 changes: 3 additions & 10 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,6 @@ jobs:
sudo cp target/release/modality-defmt-importer /usr/lib/modality-reflector-plugins/importers/
sudo cp target/release/modality-defmt-rtt-collector /usr/lib/modality-reflector-plugins/collectors/
# NOTE: We're going to run the importer as a collector
# this will change once we add import support to our reflector docker image
sudo cp target/release/modality-defmt-importer /usr/lib/modality-reflector-plugins/collectors/
- name: Create specs
run: |
conform spec create --file test_system/specs/tests.speqtr tests
Expand Down Expand Up @@ -154,14 +150,11 @@ jobs:
-v "$(pwd)/target/thumbv7em-none-eabihf/release/atsamd-rtic-firmware:/atsamd-rtic-firmware" \
-v "/tmp/rtt_log.bin:/rtt_log.bin" \
-e MODALITY_AUTH_TOKEN="${{env.MODALITY_AUTH_TOKEN}}" \
-e REFLECTOR_OPTS="--config /reflector-config.toml --collector defmt" \
-d --rm \
-e IMPORT=1 \
-e REFLECTOR_OPTS="--config /reflector-config.toml defmt" \
${image}
# NOTE: this will go away once we switch to reflector import
sleep 2
modality wait-until --deadline '4m' 'panic@* aggregate count() = 1'
docker container stop reflector
modality workspace sync-indices
- name: Inspect data
env:
Expand Down
4 changes: 1 addition & 3 deletions test_system/config/reflector-config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ additional-timeline-attributes = [
"module='defmt-test-system'",
]

# NOTE: this should be an importer once we add that workflow to the docker image
#[plugins.ingest.importers.defmt.metadata]
[plugins.ingest.collectors.defmt.metadata]
[plugins.ingest.importers.defmt.metadata]
client-timeout = "2s"
open-timeout = "10s"
rtos-mode = "rtic1"
Expand Down

0 comments on commit 07af51b

Please sign in to comment.