-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rh_kselftests_vm.mm: updates the pattern based on the guest OS version #4256
Merged
yanan-fu
merged 1 commit into
autotest:master
from
mcasquer:3352_selftests_rhel8_compatibility
Feb 19, 2025
Merged
rh_kselftests_vm.mm: updates the pattern based on the guest OS version #4256
yanan-fu
merged 1 commit into
autotest:master
from
mcasquer:3352_selftests_rhel8_compatibility
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zhencliu
reviewed
Feb 6, 2025
3465091
to
85d8dc1
Compare
Now the test is compatible with different versions
|
@zhencliu this is a kindly reminder, please could you review again this PR? Thanks ! |
zhencliu
reviewed
Feb 18, 2025
The output of the selftests changes, for RHEL 8 versions, it seems to not contain hastags '#' at the beggining of each line. Opportunistically, increase the RPM download timeout. Signed-off-by: mcasquer <mcasquer@redhat.com>
85d8dc1
to
3ccc1a3
Compare
Test case passed on both RHEL 8.10 and RHEL 9.6.0
|
zhencliu
approved these changes
Feb 19, 2025
yanan-fu
reviewed
Feb 19, 2025
yanan-fu
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rh_kselftests_vm.mm: updates the pattern based on the guest OS version
The output of the selftests changes, for RHEL 8 versions, it
seems to not contain hastags '#' at the beggining of each line.
Opportunistically, increase the RPM download timeout.
Signed-off-by: mcasquer mcasquer@redhat.com
ID: 3352