hugepage_reset: Test compatible with different NUMA topologies #4237
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please @JinLiul could you test this PR whenever you have a 8 NUMA nodes system again? Thanks! |
|
Hi @mcasquer, tested with 8 NUMA nodes system. |
As the test will set 8 hugepages, this works fine for systems with 2 NUMA nodes, having e.g. 8 nodes is going to lead the on_numa_node variant to fail since the binded node doesn't have enough hugepages. As the cfg already suggests to allocate 1G hugepages on boot time, let's make user decision how many hugepages allocate, adding an informative comment in the cfg as well. Finally, if system hugepage_size is 1GB, allocates at runtime enough hugepages in all valid nodes. Signed-off-by: mcasquer <mcasquer@redhat.com>
mcasquer
force-pushed
the
3254_hp_reset_setup
branch
from
5e1c2c5 to
b1013a9
Compare
mcasquer
changed the title
|
Tests results on a 8 NUMA nodes host (with test loop a bit tuned 😁) |
|
Please @JinLiul could you test again this PR? Thanks ! |
|
Also passed in 2 NUMA nodes host |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hugepage_reset: Test compatible with different NUMA topologies
As the test will set 8 hugepages, this works fine
for systems with 2 NUMA nodes, having e.g. 8 nodes
is going to lead the on_numa_node variant to fail
since the binded node doesn't have enough hugepages.
As the cfg already suggests to allocate 1G hugepages
on boot time, let's make user decision how many hugepages
allocate, adding an informative comment in the cfg as well.
Finally, if system hugepage_size is 1GB, allocates at
runtime enough hugepages in all valid nodes.
Signed-off-by: mcasquer mcasquer@redhat.com
ID: 3254