Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fio_windows: Update new check method for fio install #3964

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fio_windows: Update new check method for fio install #3964

merged 1 commit into from
Mar 19, 2024

Conversation

peixiu
Copy link
Contributor

@peixiu peixiu commented Feb 22, 2024

The original judge condition does not so accurate, change it more accurate here.

ID: 1865
Signed-off-by: Peixiu Hou phou@redhat.com

@peixiu
Copy link
Contributor Author

peixiu commented Feb 22, 2024

Hi @qingwangrh @yanan-fu,

Could you help to review this patch? thanks~

Tested passed:
python3 ConfigTest.py --testcase=ioeventfd.block.under_stress,,fio_windows --guestname=Win11 --platform=x86_64 --clone=no --machines=q35

(1/3) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.ioeventfd.under_stress.q35: STARTED
(1/3) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.ioeventfd.under_stress.q35: PASS (870.85 s)
(2/3) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fio_windows.aio_native.q35: STARTED
(2/3) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fio_windows.aio_native.q35: PASS (569.36 s)
(3/3) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fio_windows.aio_threads.q35: STARTED
(3/3) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fio_windows.aio_threads.q35: PASS (533.58 s)

@yanan-fu
Copy link
Contributor

Comment in the issue, could you have a look, thanks!

@peixiu peixiu force-pushed the fio_windows_fix branch from 04bf7e8 to 4a0dc72 Compare March 5, 2024 01:13
@peixiu
Copy link
Contributor Author

peixiu commented Mar 5, 2024 •
edited
Loading

Comment in the issue, could you have a look, thanks!

Hi @yanan-fu ,

Fixed storage_benchmark cannot clean the fio directory issue with the new updates.
The issue root cause is, clean method create a new session for remove_env function, but there's an exists session for fio_installation, this session uses the fio directory, but it is not be closed after fio install finished.
I closed it at the install_win function finished.

Please help to review it again, thanks~

@qingwangrh
Copy link
Contributor

Delete the folder or check the EXE file both are acceptable to me.

LGTM

@peixiu
fio_windows: Update new check method for fio install
0f643b3 
1. The original fio installed judge condition does not accurate,
   change new here.
2. storage_benchmark remove fio does not clean since fio directory
   remain using, solve this problem as well.

Signed-off-by: Peixiu Hou <phou@redhat.com>
@peixiu
Copy link
Contributor Author

peixiu commented Mar 18, 2024

Tried tests: ioeventfd.under_stress job can clean fio directory when job finished, and fio_windows, iozone_windows also passed with the new code.

(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.ioeventfd.under_stress.q35: STARTED
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.ioeventfd.under_stress.q35: PASS (545.83 s)

(1/6) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fio_windows.aio_native.q35: STARTED
(1/6) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fio_windows.aio_native.q35: PASS (211.75 s)
(2/6) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fio_windows.aio_threads.q35: STARTED
(2/6) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fio_windows.aio_threads.q35: PASS (215.93 s)
(3/6) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.iozone_windows.aio_native.q35: STARTED
(3/6) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.iozone_windows.aio_native.q35: PASS (259.63 s)
(4/6) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.iozone_windows.aio_threads.q35: STARTED
(4/6) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.iozone_windows.aio_threads.q35: PASS (243.57 s)

yanan-fu
yanan-fu approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@yanan-fu yanan-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@yanan-fu yanan-fu merged commit 7db3d9e into autotest:master Mar 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanan-fu yanan-fu yanan-fu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peixiu @yanan-fu @qingwangrh