Installer test: add static DNS configuration test #3937

heywji · 2024-01-07T15:57:47Z

Driver installer supports restoring DNS configurations after driver upgrade, so add a DNS checkpoint here. The previous static IP configuration test was #3860

ID: 1561

Signed-off-by: wji wji@redhat.com

heywji · 2024-01-07T15:58:28Z

Test Result:

CaseName                                 Status          StartTime       EndTime         Result     TimeElapsed
1-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-01-07 22:46:39 2024-01-07 23:01:28 PASS 888.374354
Summary:
Finshed=1, PASS=1

heywji · 2024-01-08T05:42:29Z

Hi @leidwang @xiagao @vivianQizhu Could you please help to review it? Thanks.

leidwang · 2024-01-09T05:39:33Z

qemu/tests/win_virtio_driver_update_by_installer.py

@@ -96,6 +96,14 @@ def change_virtio_media(cdrom_virtio):
            static_ip_address = utils_net.get_guest_ip_addr(session_serial, virtio_nic_mac, os_type='windows')
            if static_ip_address != params["static_ip"]:
                test.fail("Failed to setup static ip,current ip is %s" % static_ip_address)
+            setup_dns_cmd = params["setup_dns_cmd"] % ifname
+            session_serial.cmd_status(setup_dns_cmd)
+            static_dns_address = utils_net.get_windows_nic_attribute(session_serial, global_switch="nicconfig",


Hi @wji

Is it possible to get the index value via the ifname/mac_address, it will be better than the hard code.
Thanks.

@heywji I understand that the old code did not follow PEP8 perfectly, we could keep them as it is. But when we introduce new lines or touch them when fix issues let's try to improve our code style. please keep each line within 79 characters.

heywji · 2024-01-15T02:45:23Z

Hi @leidwang, Could you help review this patch again since it gets the index value via the mac_address now?

leidwang · 2024-01-16T06:28:55Z

Hi @leidwang, Could you help review this patch again since it gets the index value via the mac_address now?

LGTM, would you please provide the test results?

heywji · 2024-01-24T09:19:29Z

Test Result:

CaseName                                 Status          StartTime       EndTime         Result     TimeElapsed
1-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35 Finshed 2024-01-24 16:11:35 2024-01-24 16:24:22 PASS 766.635205
2-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35 Finshed 2024-01-24 16:24:22 2024-01-24 16:40:30 PASS 967.610786
3-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-01-24 16:40:30 2024-01-24 16:56:19 PASS 948.4478
4-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-01-24 16:56:19 2024-01-24 17:12:03 PASS 944.242369
Summary:
Finshed=4, PASS=4

heywji · 2024-01-24T09:23:35Z

Hi @leidwang @vivianQizhu, Please help me review this patch again when you are free. Thanks a lot : )

leidwang · 2024-01-26T08:51:33Z

qemu/tests/win_virtio_driver_update_by_installer.py

@@ -128,6 +136,14 @@ def change_virtio_media(cdrom_virtio):
        static_ip_address = utils_net.get_guest_ip_addr(session_serial, virtio_nic_mac, os_type='windows')
        if static_ip_address != params["static_ip"]:
            test.fail("Static ip is lost after upgrade driver,current ip is %s" % static_ip_address)
+        setup_dns_cmd = params["setup_dns_cmd"] % ifname
+        session_serial.cmd_status(setup_dns_cmd)


Hi @heywji

IMO, we should not set dns again, just check if previous dns setting is valid.

Thanks.

Hi @leidwang, I tried that. If I don't set it, I will get "c:\windows\system32".

This should be another problem.
Back to our test case, the checkpoint is to check if the static dns can be saved after upgrading the driver. If we set the DNS again after upgrading the driver, then our checkpoint will not be tested at all, which is meaningless.

@leidwang You are right. I will change my code and find the root cause.

I am fixing a similar bug, not sure if the error you hit is same with me, I will send you the patch.You can try to run your patch with my fix first.

I have already solved this problem.
There are two issues contained here, so let me explain.
The first one about 'c:\\windows\\system32' comes from your patch-related problem.
The second problem is a runtime error. The root cause of this problem comes from the fact that the developers fixed this problem in virtio-win-1.9.36-0.el9_3.iso, and I was using a lower version before. So that, it is normal that the DNS information is not found.

It works now. Thanks leidong.

In short, I was using the wrong iso. Sorry :(

heywji · 2024-02-26T10:34:39Z

Test Result:

1-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-26 16:56:55 2024-02-26 17:24:39 PASS 1664.016673
2-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-26 17:24:39 2024-02-26 17:51:37 PASS 1617.687452
Summary:
Finshed=2, PASS=2

heywji · 2024-02-26T10:45:09Z

Hi @leidwang, Could you please help to review this again when you are free?

Thanks in advance.

heywji · 2024-02-27T03:41:30Z

I just pushed the wrong branch, but it is normal now.

leidwang

LGTM.

vivianQizhu · 2024-02-27T08:39:02Z

qemu/tests/win_virtio_driver_update_by_installer.py

+        static_dns_address = utils_net.get_windows_nic_attribute(session_serial, global_switch="nicconfig",
+                                                                 key="MACAddress", value=f"{virtio_nic_mac}",
+                                                                 target="DNSServerSearchOrder")
+        static_dns_address = static_dns_address.strip('{}').strip('"')
+        if static_dns_address != params["static_dns"]:
+            test.fail("Static dns is lost after upgrade driver,current dns is %s" % static_dns_address)


@heywji Shall we consider package these lines into a function as you repeat exactly the same lines twice.

OK! I will change it now.

Hi @vivianQizhu, I have put these lines into a function. Could you please check them again?

Test Result: Pass

Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35: PASS (955.86 s)

vivianQizhu · 2024-02-28T02:11:31Z

qemu/tests/win_virtio_driver_update_by_installer.py

            static_ip_address = utils_net.get_guest_ip_addr(session_serial, virtio_nic_mac, os_type='windows')
            if static_ip_address != params["static_ip"]:
                test.fail("Failed to setup static ip,current ip is %s" % static_ip_address)


@heywji These lines also could be included into the function.

Done.

Test Result: pass

Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35: PASS (960.66 s)

qemu/tests/win_virtio_driver_update_by_installer.py

heywji · 2024-02-28T21:53:28Z

Test Result:

CaseName                                 Status          StartTime       EndTime         Result     TimeElapsed
01-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35 Finshed 2024-02-28 16:56:07 2024-02-28 17:27:52 PASS 1905.263458
02-repeat1.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 17:27:53 2024-02-28 17:48:43 PASS 1249.919158
03-repeat2.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 17:48:44 2024-02-28 18:09:31 PASS 1246.935041
04-repeat3.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 18:09:31 2024-02-28 18:30:32 PASS 1260.926943
05-repeat4.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 18:30:33 2024-02-28 18:51:26 PASS 1253.629489
06-repeat5.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 18:51:27 2024-02-28 19:12:42 PASS 1275.458846
07-repeat6.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 19:12:43 2024-02-28 19:33:51 PASS 1268.227964
08-repeat7.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 19:33:52 2024-02-28 19:54:57 PASS 1265.19864
09-repeat8.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 19:54:58 2024-02-28 20:16:28 PASS 1290.261734
10-repeat9.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 20:16:29 2024-02-28 20:38:14 PASS 1305.708692
11-repeat10.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-02-28 20:38:15 2024-02-28 20:59:44 PASS 1288.697793
Summary:
Finshed=11, PASS=11

qemu/tests/win_virtio_driver_update_by_installer.py

Driver installer supports restoring DNS configurations after driver upgrade, so add a DNS checkpoint here. Reference: The previous static IP configuration test was autotest#3860 Signed-off-by: wji <wji@redhat.com>

vivianQizhu · 2024-03-01T06:06:53Z

@heywji Latest test result please. Thanks.

heywji · 2024-03-01T07:03:56Z

Test Result: PASS

01-repeat1.Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_update.from_old_installer.q35 Finshed 2024-03-01 14:30:32 2024-03-01 14:53:08 PASS 1356.027594

heywji force-pushed the add_dns_test branch 2 times, most recently from f2b2522 to ce819cf Compare January 7, 2024 16:12

leidwang reviewed Jan 9, 2024

View reviewed changes

heywji force-pushed the add_dns_test branch 4 times, most recently from 2a75c49 to 4ce5b54 Compare January 12, 2024 02:57

heywji force-pushed the add_dns_test branch 4 times, most recently from 57d1e21 to da5f7b6 Compare January 24, 2024 08:09

leidwang reviewed Jan 26, 2024

View reviewed changes

heywji force-pushed the add_dns_test branch from da5f7b6 to a6321b5 Compare February 26, 2024 09:18

heywji force-pushed the add_dns_test branch 2 times, most recently from 3df5811 to a6321b5 Compare February 27, 2024 03:24

leidwang approved these changes Feb 27, 2024

View reviewed changes

vivianQizhu reviewed Feb 27, 2024

View reviewed changes

heywji force-pushed the add_dns_test branch 4 times, most recently from 8fdca88 to 0406768 Compare February 27, 2024 09:17

heywji force-pushed the add_dns_test branch 3 times, most recently from e4b690d to 902a123 Compare February 27, 2024 09:39

vivianQizhu reviewed Feb 28, 2024

View reviewed changes

heywji force-pushed the add_dns_test branch 3 times, most recently from f94bbb4 to 1e1c801 Compare February 28, 2024 03:07

vivianQizhu reviewed Feb 28, 2024

View reviewed changes

qemu/tests/win_virtio_driver_update_by_installer.py Show resolved Hide resolved

heywji force-pushed the add_dns_test branch from 1e1c801 to 9e0b579 Compare February 28, 2024 05:58

vivianQizhu reviewed Feb 28, 2024

View reviewed changes

qemu/tests/win_virtio_driver_update_by_installer.py Show resolved Hide resolved

heywji force-pushed the add_dns_test branch from 9e0b579 to 06e6d98 Compare February 28, 2024 08:45

heywji force-pushed the add_dns_test branch from 06e6d98 to a17e924 Compare February 29, 2024 02:40

vivianQizhu reviewed Feb 29, 2024

View reviewed changes

qemu/tests/win_virtio_driver_update_by_installer.py Show resolved Hide resolved

Installer test: add static DNS configuration test

e96e664

Driver installer supports restoring DNS configurations after driver upgrade, so add a DNS checkpoint here. Reference: The previous static IP configuration test was autotest#3860 Signed-off-by: wji <wji@redhat.com>

heywji force-pushed the add_dns_test branch from a17e924 to e96e664 Compare February 29, 2024 03:22

vivianQizhu approved these changes Mar 1, 2024

View reviewed changes

vivianQizhu merged commit 7a5cae1 into autotest:master Mar 1, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Installer test: add static DNS configuration test #3937

Installer test: add static DNS configuration test #3937

heywji commented Jan 7, 2024

heywji commented Jan 7, 2024

heywji commented Jan 8, 2024

leidwang Jan 9, 2024

vivianQizhu Feb 27, 2024

heywji commented Jan 15, 2024

leidwang commented Jan 16, 2024

heywji commented Jan 24, 2024

heywji commented Jan 24, 2024

leidwang Jan 26, 2024

heywji Jan 26, 2024

leidwang Jan 26, 2024

heywji Jan 26, 2024

leidwang Jan 26, 2024

heywji Feb 26, 2024

heywji Feb 26, 2024

heywji commented Feb 26, 2024

heywji commented Feb 26, 2024

heywji commented Feb 27, 2024

leidwang left a comment

vivianQizhu Feb 27, 2024

heywji Feb 27, 2024

heywji Feb 28, 2024

vivianQizhu Feb 28, 2024

heywji Feb 28, 2024

heywji Feb 28, 2024

heywji commented Feb 28, 2024

vivianQizhu commented Mar 1, 2024

heywji commented Mar 1, 2024

Installer test: add static DNS configuration test #3937

Installer test: add static DNS configuration test #3937

Conversation

heywji commented Jan 7, 2024

heywji commented Jan 7, 2024

heywji commented Jan 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heywji commented Jan 15, 2024

leidwang commented Jan 16, 2024

heywji commented Jan 24, 2024

heywji commented Jan 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heywji commented Feb 26, 2024

heywji commented Feb 26, 2024

heywji commented Feb 27, 2024

leidwang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heywji commented Feb 28, 2024

vivianQizhu commented Mar 1, 2024

heywji commented Mar 1, 2024