qemu_guest_agent: adjust change for the version name of mingw-qga #3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6-dehan
force-pushed
the
for-KVMAUTOMA-1229-getspecific-mingw-qga-win
branch
from
0d042ac to
f9e2420
Compare
|
@leidwang could you please help to review it? |
leidwang
reviewed
Jan 18, 2024
6-dehan
force-pushed
the
for-KVMAUTOMA-1229-getspecific-mingw-qga-win
branch
2 times, most recently
from
0f1442f to
734cc23
Compare
leidwang
reviewed
Feb 21, 2024
6-dehan
force-pushed
the
for-KVMAUTOMA-1229-getspecific-mingw-qga-win
branch
2 times, most recently
from
6871c4e to
b348585
Compare
leidwang
reviewed
Feb 21, 2024
6-dehan
force-pushed
the
for-KVMAUTOMA-1229-getspecific-mingw-qga-win
branch
from
b348585 to
5b70d73
Compare
leidwang
approved these changes
Feb 21, 2024
|
@vivianQizhu Could you please help to review and merge? |
6-dehan
force-pushed
the
for-KVMAUTOMA-1229-getspecific-mingw-qga-win
branch
from
5b70d73 to
ac2fe14
Compare
vivianQizhu
reviewed
Feb 22, 2024
qemu/tests/qemu_guest_agent.py
Outdated
| @@ -3933,13 +3933,18 @@ def get_qga_pkg_path(self, qemu_ga_pkg, test, session, params, vm): | |||
| if self.gagent_src_type == "url": | |||
| gagent_host_path = params["gagent_host_path"] | |||
| gagent_download_url = params["gagent_download_url"] | |||
| mqgaw_ver = re.search(r'(?:\d+\.){2}\d+', gagent_download_url) | |||
| mqgaw_ver_list = list(map(int, mqgaw_ver.group(0).split('.'))) | |||
| mqgaw_name = "mingw-qemu-ga-win" if mqgaw_ver_list >= [105, 0, 1] else "qemu-ga-win" | |||
There was a problem hiding this comment.
Please limit each line within 79 characters.
Also I would suggest to define a variants for "mingw-qemu-ga-win" and "qemu-ga-win" in cfg file like qga_bin or qga_bin_legacy
There was a problem hiding this comment.
(2/2) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_freeze_frozen.q35: PASS (183.73 s)
the name of qemu-ga-win has been changed to mingw-qemu-ga-win, so the logic of getting specific version of package should be adjusted as well. Signed-off-by: Dehan Meng <demeng@redhat.com>
6-dehan
force-pushed
the
for-KVMAUTOMA-1229-getspecific-mingw-qga-win
branch
from
ac2fe14 to
0655fa4
Compare
vivianQizhu
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the name of qemu-ga-win has been changed to mingw-qemu-ga-win, so the logic of getting specific version of package should be adjusted as well.
ID: 1229
Signed-off-by: Dehan Meng demeng@redhat.com