Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtio_fs:compare symbolic link info in host and guest #3895

Merged
merged 1 commit into from
Dec 6, 2023
Merged

virtio_fs:compare symbolic link info in host and guest #3895

merged 1 commit into from
Dec 6, 2023

Conversation

zhenyzha
Copy link
Contributor

@zhenyzha zhenyzha commented Nov 28, 2023 •
edited
Loading

Compare symbolic link information in the Linux host and
guest to check if they are consistent.

ID: 1564

@zhenyzha zhenyzha force-pushed the sym_link branch 4 times, most recently from 1777d27 to a99e67d Compare November 30, 2023 06:19
@zhenyzha zhenyzha marked this pull request as ready for review November 30, 2023 06:22
@zhenyzha
Copy link
Contributor Author

@fbq815 @xiagao @YongxueHong
Could you pls help review it when you are free. thanks.

virtio_fs_share_data.with_symbolic_link PASS 3

fbq815
fbq815 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@fbq815 fbq815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test result on s390x:
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@xiagao
Copy link
Contributor

xiagao commented Dec 4, 2023

@zhenyzha Seems that this fix doesn't cover Windows guest, if you don't intend to cover it, could you pls update the commit info? Thanks.

@xiagao
Copy link
Contributor

xiagao commented Dec 4, 2023

Test pass with x86_64 with RHEL guest.
RESULTS : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@zhenyzha
Copy link
Contributor Author

zhenyzha commented Dec 5, 2023

@zhenyzha Seems that this fix doesn't cover Windows guest, if you don't intend to cover it, could you pls update the commit info? Thanks.

Already updated, thanks for the review.

@zhenyzha
virtio_fs:compare symbolic link info in host and guest
c374ad9 
Compare symbolic link information in the Linux host and
guest to check if they are consistent.

Signed-off-by: zhenyzha <zhenyzha@redhat.com>
@zhenyzha
Copy link
Contributor Author

zhenyzha commented Dec 5, 2023

virtio_fs_share_data..with_symbolic_link PASS 3
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@xiagao @YongxueHong
Could you pls help review again it when you are free? thanks.

@YongxueHong YongxueHong merged commit e2a2f0b into autotest:master Dec 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiagao xiagao xiagao approved these changes

@YongxueHong YongxueHong YongxueHong approved these changes

@fbq815 fbq815 fbq815 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhenyzha @xiagao @YongxueHong @fbq815