Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the ipv6 link local syntax for rhel9 #3874

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Change the ipv6 link local syntax for rhel9 #3874

merged 1 commit into from
Dec 7, 2023

Conversation

yanglei-rh
Copy link
Contributor

Since from rhel9,ipv6 link local's scp syntax has been changed. So QE sent a MR to fix this problem.

ID: 1530
Signed-off-by: Lei Yang leiyang@redhat.com

@yanglei-rh
Copy link
Contributor Author

yanglei-rh commented Nov 14, 2023 •
edited
Loading

Test pass:
rhel 9: (1/1) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.bigfile_transfer_over_ipv6.link_local_addr.q35: PASS (549.24 s)
rhel 8: (1/1) Host_RHEL.m8.u9.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.x86_64.io-github-autotest-qemu.bigfile_transfer_over_ipv6.link_local_addr.q35: PASS (253.53 s)

@yanglei-rh
Copy link
Contributor Author

@PaulYuuu Could you please help me review this patch? Thanks in advance.

@PaulYuuu
Copy link
Contributor

@yanglei-rh, so is it a bug? Or a reasonable change, as this looks quite strange. So I am not sure if it will fallback in the future, maybe this is just a workaround?

@yanglei-rh
Copy link
Contributor Author

@yanglei-rh, so is it a bug? Or a reasonable change, as this looks quite strange. So I am not sure if it will fallback in the future, maybe this is just a workaround?

After discussion this problem with developer, I think this is a reasonable change, because of I changed that product bug to notabug, the developer does not correct me. But your concern also make sense, I will continue to track this problem in the future.

@yanglei-rh
Copy link
Contributor Author

Hello @PaulYuuu Could you please help review this patch again when you have free time?

PaulYuuu
PaulYuuu reviewed Nov 30, 2023
View reviewed changes
@yanglei-rh yanglei-rh force-pushed the KVMAUTOMA-1530 branch 2 times, most recently from 7fc359f to 199fe27 Compare November 30, 2023 09:36
Change the ipv6 link local syntax for rhel9
ad24fe4 
Since from rhel9,ipv6 link local's scp syntax has been changed. So QE
sent a MR to fix this problem.

Signed-off-by: Lei Yang <leiayang@redhat.com>
@yanglei-rh
Copy link
Contributor Author

It can test pass on rhel 9 and rhel 8 host.

@PaulYuuu PaulYuuu merged commit 7bebb67 into autotest:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulYuuu PaulYuuu PaulYuuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanglei-rh @PaulYuuu