Skip to content

Commit

Permalink
hugepage_reset: removes hugepages setup
Browse files Browse the repository at this point in the history
As the test will set 8 hugepages, this works fine
for systems with 2 NUMA nodes, having e.g. 8 nodes
is going to lead the on_numa_node variant to fail
since the binded node doesn't have enough hugepages.

As the cfg already suggests to allocate 1G hugepages
on boot time, let's make user decision how many hugepages
allocate, adding an informative comment in the cfg as well.

Signed-off-by: mcasquer <mcasquer@redhat.com>
  • Loading branch information
mcasquer committed Dec 18, 2024
1 parent 561916a commit 5e1c2c5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 4 additions & 2 deletions qemu/tests/cfg/hugepage_reset.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
pre_command = 'echo 3 > /proc/sys/vm/drop_caches && echo 1 > /proc/sys/vm/compact_memory'
mem = 4096
origin_nr = 8
# Please set hugepage in kernel command line before this test:
# default_hugepagesz=1G hugepagesz=1G hugepages=8
# Please allocate enough hugepages at boot time for this test.
# IMPORTANT! Keep in mind the system memory and the number of NUMA nodes
# to decide how many hugepages are needed to be allocated.
# Example: default_hugepagesz=1G hugepagesz=1G hugepages=24
expected_hugepage_size = 1048576
Windows:
x86_64:
Expand Down
2 changes: 0 additions & 2 deletions qemu/tests/hugepage_reset.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ def heavyload_install():
)
hp_config = test_setup.HugePageConfig(params)
hp_config.target_hugepages = origin_nr
test.log.info("Setup hugepage number to %s", origin_nr)
hp_config.setup()
hugepage_size = utils_memory.get_huge_page_size()
params["hugepage_path"] = hp_config.hugepage_path
params["start_vm"] = "yes"
Expand Down

0 comments on commit 5e1c2c5

Please sign in to comment.