-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Remove Cython - Reduce tech debt #346
Changes from 13 commits
ff0f2b2
e915964
2a29120
79decbd
add84b5
a3f4297
60dc4db
279cac2
3bc359f
b7f5d9d
fb368c4
e4064cf
5ebd21f
a4916be
4ab1c80
584b8ef
87eb45d
fceffa6
ba1cb59
26430fd
5fb53f6
82e3fab
147e6ec
07687f2
99cd93b
0df82ec
8da216d
55b9190
fb3fc42
68a0fbb
a75708e
ef96506
5af481f
83cb54c
0a11215
b699216
940c403
f58a387
cb335b9
7e2f97f
fab4b07
f913bc2
cf2dd67
0bbd7a9
60791ab
2a7cbdd
f9b0cf7
631a1e5
4fb2787
9fe50d9
79682ea
ba65910
574d355
4ab87f3
ac906a4
d88c6bd
945df4c
693d64d
451766f
4515a8a
3b54021
3fe243b
cb74fde
470071b
77522df
222b097
5f65e5a
636f0b6
9c8a0c9
560ada3
08b8cf9
ad79b5c
4cdb5b3
9d66f56
d144026
a4467f4
f773910
215256a
01c68c6
e94825d
05fbe4b
8a9d51f
f6d1343
dbaab3f
f84cbd4
5b65f45
669b108
107204b
2f495d1
8a4ac0b
369803c
5152f9e
cc5fd78
cf011bf
bc3afcd
2a48d08
995c417
09beefd
debe675
897bec7
b1f1fb9
80e2c7c
d23879d
de0b36e
82d66fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,72 +1,27 @@ | ||
# This workflow is just to test that the docs build successfully. | ||
name: docs | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
cancel-in-progress: true | ||
on: | ||
# Trigger manually | ||
workflow_dispatch: | ||
|
||
# Trigger on any push to the main | ||
push: | ||
branches: | ||
- main | ||
- development | ||
|
||
# Trigger on any push to a PR that targets main | ||
pull_request: | ||
branches: | ||
- main | ||
- development | ||
|
||
permissions: | ||
contents: write | ||
|
||
env: | ||
name: "ConfigSpace" | ||
|
||
jobs: | ||
build-and-deploy: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup Python | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: "3.8" | ||
|
||
- name: Install dependencies | ||
run: | | ||
pip install build | ||
pip install ".[docs]" | ||
|
||
- name: Make docs | ||
run: | | ||
make clean | ||
make docs | ||
|
||
- name: Pull latest gh-pages | ||
if: (contains(github.ref, 'develop') || contains(github.ref, 'main')) && github.event_name == 'push' | ||
run: | | ||
cd .. | ||
git clone https://github.com/${{ github.repository }}.git --branch gh-pages --single-branch gh-pages | ||
|
||
- name: Copy new docs into gh-pages | ||
if: (contains(github.ref, 'develop') || contains(github.ref, 'main')) && github.event_name == 'push' | ||
run: | | ||
branch_name=${GITHUB_REF##*/} | ||
cd ../gh-pages | ||
rm -rf $branch_name | ||
cp -r ../${{ env.name }}/docs/build/html $branch_name | ||
|
||
- name: Push to gh-pages | ||
if: (contains(github.ref, 'develop') || contains(github.ref, 'main')) && github.event_name == 'push' | ||
run: | | ||
last_commit=$(git log --pretty=format:"%an: %s") | ||
cd ../gh-pages | ||
branch_name=${GITHUB_REF##*/} | ||
git add $branch_name/ | ||
git config --global user.name 'Github Actions' | ||
git config --global user.email 'not@mail.com' | ||
git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }} | ||
git commit -am "$last_commit" | ||
git push | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.10" | ||
- name: "Install dependancies" | ||
run: python -m pip install -e ".[dev]" | ||
- name: "Build Docs" | ||
run: mkdocs build --clean --strict | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,11 +32,9 @@ env: | |
--durations=20 | ||
-v | ||
|
||
|
||
jobs: | ||
test: | ||
|
||
# General unit tests | ||
source-test: | ||
name: ${{ matrix.python-version }}-${{ matrix.os }} | ||
|
||
runs-on: ${{ matrix.os }} | ||
|
@@ -49,12 +47,6 @@ jobs: | |
matrix: | ||
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | ||
os: ["ubuntu-latest", "macos-latest", "windows-latest"] | ||
exclude: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do this work now? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apparently so |
||
# These don't seem to be available anymore with setup-python? | ||
- python-version: "3.8" | ||
os: "macos-latest" | ||
- python-version: "3.9" | ||
os: "macos-latest" | ||
|
||
steps: | ||
- name: Checkout | ||
|
@@ -64,13 +56,13 @@ jobs: | |
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
cache: pip | ||
cache-dependency-path: pyproject.toml | ||
|
||
- name: Install ${{ env.package-name }} | ||
run: | | ||
python -m pip install --upgrade pip | ||
python -m pip install -e ".${{ env.extra-requires }}" | ||
|
||
- name: Tests | ||
timeout-minutes: 45 | ||
run: | | ||
pytest ${{ env.pytest-args }} ${{ env.test-dir }} | ||
pytest ${{ env.test-dir }} |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, is there a reason you removed the pushing of the documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, we moved away from Sphinx and I didn't know how to automate doc deployments given this setup. I will document how to do it in manual way in
CONTRIBUTING.md