-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.2.2 #261
Release 2.2.2 #261
Conversation
Reviewer's Guide by SourceryThis pull request addresses breaking changes introduced in No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide more detailed release notes that summarize the specific changes from PRs Support Artifactory backend under Python 3.12 #259 and TST: adjust to new audeer error messages #260 that are included in this release.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be approved. The issue that I had turned out to be a non-issue.
The fix for Python 3.12 they introduced in
dohq-artifactory
1.0.0 had some breaking changes how path names are returned (e.g./
at the end of an URL was removed), so I had to adjust the code here as well (done in #260). I then enabled support for Artifactory Python 3.12 here as well (done in #259).