Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup audbackend.interface.Maven.ls() #226

Merged
merged 3 commits into from
May 13, 2024
Merged

Speedup audbackend.interface.Maven.ls() #226

merged 3 commits into from
May 13, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented May 13, 2024

In its current implementation, the execution time of audbackend.interface.Maven.ls() scales with the content of the repository / sub-folder, as it first collects all files given under root or a sub-folder, and limits the results only afterwards for the requested file.

As all versioned belonging to a file are stored in the the sub-folder <root>/<name>/ there is no need for this. In this pull request, I use ls() of the underlying backend object to inspect the content of that folder and hence speed up the execution time.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (bdc5368) to head (8aa9d92).

Additional details and impacted files
Files Coverage Δ
audbackend/core/interface/maven.py 100.0% <100.0%> (ø)

@hagenw hagenw requested a review from frankenjoe May 13, 2024 08:42
@hagenw
Copy link
Member Author

hagenw commented May 13, 2024

This is also the one advantage we have with the Maven interface, compared to the Versioned interface, as in Versioned we cannot limit the listing of files that easily.

@frankenjoe frankenjoe merged commit 503bae9 into main May 13, 2024
9 checks passed
@frankenjoe frankenjoe deleted the speedup-maven branch May 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants