-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create(): remove return value #174
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
In the text of the docstring the |
Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
Good point. Changed it also for |
Cool, thanks. Should we maybe add a note to the docstring of |
Yes, I guess a note would not hurt. One problem is of course that we cannot show a deprecation warning, since we do not know when the user uses the returned value. So maybe we simply say it might be removed in a future version? And one more thing I noticed. Lately we started to talk about "repository" instead of "backend object" (see description). To me it makes more sense since the common user will not directly interact with the backend object anyway and repository is probably more descriptive. But maybe we should unify it across all api functions. In |
Yes, I also switched talking more about repository in #171 (but so far restricted to the usage section of the documentation). I would simply write future version in the notes as it is not so easy to forsee the upcoming versions of |
* create(): remove interface argument * TST: update * DOC: update * create(): add legacy note * Update audbackend/core/api.py Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com> * Update audbackend/core/api.py Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com> * DOC: remove redudant description * DOC: remove redudant description * fix linter errors * Doc: add not one undocumnted return value --------- Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
* create(): remove interface argument * TST: update * DOC: update * create(): add legacy note * Update audbackend/core/api.py Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com> * Update audbackend/core/api.py Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com> * DOC: remove redudant description * DOC: remove redudant description * fix linter errors * Doc: add not one undocumnted return value --------- Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
Closes #173
This (officially) removes the return value from
audbackend.create()
. For legacy reasons we still return an instance ofaudbackend.interface.Versioned
.