Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend sub module #172

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Backend sub module #172

merged 4 commits into from
Jan 24, 2024

Conversation

frankenjoe
Copy link
Collaborator

@frankenjoe frankenjoe commented Jan 23, 2024

Closes #170

Moves audbackend.Backend, audbackend.Artifactory, audbackend.FileSystem to sub-module audbackend.backend and renames Backend to Base.

For backward compatibility the old imports are still supported (tested in tests/test_legacy_import.py).

Documentation

image

image

image

image

@frankenjoe frankenjoe marked this pull request as draft January 23, 2024 16:40
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d94b6e2) 100.0% compared to head (e3fb906) 100.0%.

Additional details and impacted files
Files Coverage Δ
audbackend/__init__.py 100.0% <100.0%> (ø)
audbackend/backend/__init__.py 100.0% <100.0%> (ø)
audbackend/core/api.py 100.0% <100.0%> (ø)
audbackend/core/backend/artifactory.py 100.0% <100.0%> (ø)
audbackend/core/backend/base.py 100.0% <100.0%> (ø)
audbackend/core/backend/filesystem.py 100.0% <100.0%> (ø)
audbackend/core/conftest.py 100.0% <100.0%> (ø)
audbackend/core/interface/base.py 100.0% <100.0%> (ø)
audbackend/core/interface/versioned.py 100.0% <ø> (ø)

@frankenjoe frankenjoe marked this pull request as ready for review January 23, 2024 17:21
@frankenjoe frankenjoe requested a review from hagenw January 23, 2024 17:22
@hagenw
Copy link
Member

hagenw commented Jan 24, 2024

Great, the separation is much nicer now between interface and backends.
It's also nice to have the backward compatibility with audbackend.Backend, but I guess the bigger chnage is anyway that audbackend.create() and audbackend.access() now return iinterfaces and not backends. But I guess it will be mainly the type hints that we need to fix in other packages.

@hagenw hagenw merged commit 232a140 into main Jan 24, 2024
9 checks passed
@hagenw hagenw deleted the backend-sub-module branch January 24, 2024 08:21
hagenw pushed a commit that referenced this pull request May 3, 2024
* make backend sub-module

* legacy imports

* DOC: update

* DOC: fix typo
hagenw pushed a commit that referenced this pull request May 3, 2024
* make backend sub-module

* legacy imports

* DOC: update

* DOC: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extra audbackend.backend sub-module?
2 participants