Remove version from implementation #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
hagenw
reviewed
Jan 18, 2024
hagenw
pushed a commit
that referenced
this pull request
May 3, 2024
* Backend: expand path with version * remove version handling * remove version handling * TST: fix test * TST: fix test of docstring examples * DOC: fix SQL example * fix linter errors * TST: fix use backend path separator when expanding path * Backend: check path and version in _path_with_version() * Backend.latest_version(): remove path check * Backend._ls(): improve docstring
hagenw
pushed a commit
that referenced
this pull request
May 3, 2024
* Backend: expand path with version * remove version handling * remove version handling * TST: fix test * TST: fix test of docstring examples * DOC: fix SQL example * fix linter errors * TST: fix use backend path separator when expanding path * Backend: check path and version in _path_with_version() * Backend.latest_version(): remove path check * Backend._ls(): improve docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #155
This removes the
versionargument from the backend implementation.Instead of forwarding
pathandversionto the implementation,Backendintegrates the version into the path now. This simplifies the implementation of a backend, since a developer does not have to care about storing the version (especially the implementation of_ls()becomes way simpler). Also the support for legacy file structure is now handled directly byBackend(and as a side-effect supported by any backend).The suggested changes will allow us to implement
audbackendin a way that it can be used without versioning as requested in #155 (not implemented here).