-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.11.2 #496
Release 1.11.2 #496
Conversation
Reviewer's Guide by SourceryThis pull request updates the changelog for the 1.11.2 release. No diagrams generated as the changes look simple and do not need a visual representation. Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changelog diff appears to be incomplete - please include the actual changes being made for release 1.11.2
- The image in the PR description appears to be broken. If it contains relevant release information, please fix the link
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked that devopshq/artifactory
does not in the meantime add support for versions >3.12. This is not the case, so all versioning info here an in audbackend are stil up to date.
I personally would rephrase this sentence:
* Added: support for Artifactory backend under Python 3.12
It is a little bit ambiguous due to the under
. I would prefer not to use it and have something like "Added support for the Artifactory backend in Python 3.12" or similar.
Apart from that I could not spot forgotten features or the like.
Therefore I think it is safet to approve.
Good points, I subscribed to devopshq/artifactory#470, so we get informed when it is fixed. I also changed the changelog text using your suggestion. |
This uses the changes introduced in audeering/audbackend#261 and applied in #495 to support Artifactory repositories under Python 3.12.