Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.11.2 #496

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Release 1.11.2 #496

merged 2 commits into from
Feb 3, 2025

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Feb 3, 2025

This uses the changes introduced in audeering/audbackend#261 and applied in #495 to support Artifactory repositories under Python 3.12.

image

Copy link
Contributor

sourcery-ai bot commented Feb 3, 2025

Reviewer's Guide by Sourcery

This pull request updates the changelog for the 1.11.2 release.

No diagrams generated as the changes look simple and do not need a visual representation.


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The changelog diff appears to be incomplete - please include the actual changes being made for release 1.11.2
  • The image in the PR description appears to be broken. If it contains relevant release information, please fix the link
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw requested a review from ChristianGeng February 3, 2025 13:30
Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked that devopshq/artifactory does not in the meantime add support for versions >3.12. This is not the case, so all versioning info here an in audbackend are stil up to date.

I personally would rephrase this sentence:

* Added: support for Artifactory backend under Python 3.12

It is a little bit ambiguous due to the under. I would prefer not to use it and have something like "Added support for the Artifactory backend in Python 3.12" or similar.

Apart from that I could not spot forgotten features or the like.
Therefore I think it is safet to approve.

@hagenw
Copy link
Member Author

hagenw commented Feb 3, 2025

Good points, I subscribed to devopshq/artifactory#470, so we get informed when it is fixed.

I also changed the changelog text using your suggestion.

@hagenw hagenw merged commit 3cc10aa into main Feb 3, 2025
10 checks passed
@hagenw hagenw deleted the release-1.11.2 branch February 3, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants