Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust to allow full FW/1 as framework beanfactory #429

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brianharcourt
Copy link

  • Lucee 5.3.8.201
  • Java 1.8.0_242 (Amazon.com Inc.) 64bit
  • Taffy 3.6.0

My implemention instantiates FW1 as:

    application.endPoints = new framework.aop(variables.diLocation,variables.diConfig);
    variables.framework.beanFactory = application.endPoints;

To get it operating I needed to make these changes:

@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for taffy-docs canceled.

Name Link
🔨 Latest commit ab72131
🔍 Latest deploy log https://app.netlify.com/sites/taffy-docs/deploys/624c4f20b6a1700008c29b05

@atuttle
Copy link
Owner

atuttle commented Apr 13, 2022

I've not used it, but since you're referencing framework.aop I assume this is actually AOP/1 instead of FW/1 or DI/1?

@brianharcourt
Copy link
Author

brianharcourt commented Apr 13, 2022

Ah - maybe I'm deploying FW/1 sub-optimally. I'm using it to get aop but I thought I was deploying the whole framework. FW/1 suggests that deploying the framework involves extends=framework.one but I'm extending taffy.core.api. The only way I could get aop was to instantiate as shown. If I tinker further I'll report here.

@atuttle
Copy link
Owner

atuttle commented Apr 19, 2022

AOP is a feature/addon for dependency injection. Indeed, aop.cfc extends DI/1:

https://github.com/framework-one/aop1/blob/bdc7b916a818bd2731c8d51122fe09f098258bba/aop.cfc#L1

Taffy supports using DI/1 as its bean factory but I've never tried it with AOP/1, which should work as a drop-in replacement for DI/1.

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for taffy-docs canceled.

Name Link
🔨 Latest commit ecef947
🔍 Latest deploy log https://app.netlify.com/sites/taffy-docs/deploys/64bf32045d9ee10008afffe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants