New noCache() method #418
Closed
New noCache() method #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds expiration headers to the response.
atuttle
requested changes
Oct 13, 2021
| "Last-Modified" = dateFormat(nowUtc, "ddd, d mmm yyyy") & " " & timeFormat(nowUtc, "HH:mm:ss") & " GMT", | ||
| "Expires" = "Mon, 26 Jul 1997 05:00:00 EST" | ||
| }> | ||
| <cfset addHeaders(headers) /> |
There was a problem hiding this comment.
I don't see this function addHeaders defined anywhere. Am I missing something?
There was a problem hiding this comment.
addHeaders()? I don't make that up. It's already one of your existing methods in api.cfc (line 1441).
https://github.com/atuttle/Taffy/blob/main/core/api.cfc#L1441
<cffunction name="addHeaders" access="public" output="false" returntype="void">
<cfargument name="headers" type="struct" required="true" />
<cfset var h = '' />
<cfif !structIsEmpty(arguments.headers)>
<cfloop list="#structKeyList(arguments.headers)#" index="h">
<cfset addHeader(name="#h#", value="#arguments.headers[h]#") />
</cfloop>
</cfif>
</cffunction>
There was a problem hiding this comment.
Ah, but being in Application.cfc doesn't make it available to serializers...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds expiration headers to the response.
Resolves #416