Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect checks for an object-like value #47

Open
thealjey opened this issue Sep 4, 2020 · 1 comment
Open

incorrect checks for an object-like value #47

thealjey opened this issue Sep 4, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@thealjey
Copy link

thealjey commented Sep 4, 2020

throughout the code there are checks like;

const value = typeof variable === "object" ? variable.value : variable;

however, typeof will also result in "object" if value is null
in which case the above code will simply fail

I'm considering making a PR in a few days to address this issue

@atulmy atulmy added enhancement New feature or request help wanted Extra attention is needed labels Sep 5, 2020
@atulmy
Copy link
Owner

atulmy commented Sep 5, 2020

@thealjey thanks for identifying the issue. Looking forward to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants