Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate type annotations #182

Closed
PeterJCLaw opened this issue Dec 22, 2024 · 6 comments · Fixed by #184
Closed

Reinstate type annotations #182

PeterJCLaw opened this issue Dec 22, 2024 · 6 comments · Fixed by #184
Assignees

Comments

@PeterJCLaw
Copy link
Contributor

In #157 we added and in #156 published type annotations for this package, however it seems that ee0a3ec removes them.

This is unfortunately breaking for consumers who are type checking expecting there to be annotations from this project.

I think the fix is to revert that commit, though it would be good to understand why the change was made/if there's a reason not to reinstate them.

@attwad
Copy link
Owner

attwad commented Dec 22, 2024

Sorry this was a mistake, let's re-add the file

@attwad
Copy link
Owner

attwad commented Dec 22, 2024

published change in v1.9.1

@attwad attwad closed this as completed Dec 22, 2024
@PeterJCLaw
Copy link
Contributor Author

@attwad thanks for the speedy response. Unfortunately I'm not sure this has quite worked -- #183 targets master, while v1.9.1 appears to have been released from main and thus doesn't contain the fix.

@attwad attwad reopened this Dec 22, 2024
@attwad
Copy link
Owner

attwad commented Dec 22, 2024

Rhaaa never try to do two things at once :D
I'll fix it on main now that it's the new default branch...

@attwad attwad closed this as completed Dec 22, 2024
@PeterJCLaw
Copy link
Contributor Author

Unfortunately I don't think that's worked either?

@PeterJCLaw
Copy link
Contributor Author

@attwad thanks for merging #184; would it be possible to have a release which contains that fix? (I wonder also if it'd be worth yanking 1.9.1 & 1.9.2 from PyPI?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants