Fix refcount calculation when copying data to heaps #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w04/fix-refcount-calculation
branch
3 times, most recently
from
86a76ec to
7903237
Compare
pguyot
force-pushed
the
w04/fix-refcount-calculation
branch
from
7903237 to
02e2e87
Compare
pguyot
force-pushed
the
w04/fix-refcount-calculation
branch
5 times, most recently
from
4e2c18c to
e8306bc
Compare
Ref count should be incremented whenever the ref counted binary is added to the mso list and decremented when the mso list is swept. Also refc_binaries are allocated with a ref count of 0 until they are made a term, with the exception of enif_alloc_resource that should be balanced by an enif_release_resource following OTP semantic. Also add a new test for heap operations including gc. Also fix race conditions with demonitor in both otp_socket and emscripten code that yielded a crash by over decrementing ref count. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w04/fix-refcount-calculation
branch
from
e8306bc to
77cfcbb
Compare
bettio
approved these changes
Feb 14, 2025
bettio
added a commit
that referenced
this pull request
Feb 15, 2025
Merge a number of fixes from release-0.6 into main. Most importantly: fix refcount calculation when copying data to heaps #1498.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref count should be incremented whenever the ref counted binary is added to
the mso list and decremented when the mso list is swept.
Also refc_binaries are allocated with a ref count of 0 until they are made
a term, with the exception of enif_alloc_resource that should be balanced
by an enif_release_resource following OTP semantic.
Also add a new test for heap operations including gc.
Also fix race conditions with demonitor in both otp_socket and emscripten
code that yielded a crash by over decrementing ref count.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later